Fix button issues, improve layout, and enhance notification handling - #192
Merged
Conversation
…tes across components
…prevent lost writes there is BUG that was very annoying cause by race condition we we update and sync happen as we update and doesn't return the latest added task. this basically fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the notification and reminder system, task creation flows, and synchronization logic across the app. The most significant changes include a more robust and user-friendly notification template handling, improved sync logic to avoid missing updates, and UI/UX enhancements for task and reminder management.
Notification and Reminder System Improvements:
AddTaskModal.jsx, ensuring consistent handling and migration of legacy reminder templates. Now, default templates are normalized, and empty lists are respected as "no reminders."LocalNotificationScheduler.jsby adding ashouldNotifyUserfunction, ensuring that notifications are only scheduled for the correct users based on assignment and circle membership. [1] [2]NotificationTemplate, and improved the UI to prevent removing all notifications when not allowed. [1] [2] [3]Synchronization Logic:
SyncEngineto coalesce concurrent sync calls, ensuring that no updates are missed when multiple syncs are triggered in quick succession. This fixes issues where newly created tasks could vanish due to stale cursors. [1] [2] [3]UI/UX Enhancements:
ChoreCardcomponent to improve the layout and interaction for action buttons, including adding a visible "ThumbDown" action, adjusting button sizes, and removing the pending chip for a cleaner look. [1] [2] [3] [4] [5] [6] [7]ChoreCardto ensure consistency and maintainability.NotificationPickerFieldto the voice task panel, making reminder selection available in voice-driven task creation. [1] [2]Other Fixes and Cleanups:
NotificationTemplate.jsxandAddTaskModal.jsx. [1] [2]Summary of Most Important Changes:
Notification and Reminder System:
Synchronization:
UI/UX:
ChoreCardaction buttons and layout, and integrated notification picker into voice task creation. [1] [2] [3] [4] [5]