Skip to content

Fix button issues, improve layout, and enhance notification handling - #192

Merged
meauxt merged 3 commits into
developfrom
0803-fixes
Aug 5, 2026
Merged

Fix button issues, improve layout, and enhance notification handling#192
meauxt merged 3 commits into
developfrom
0803-fixes

Conversation

@meauxt

@meauxt meauxt commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and fixes to the notification and reminder system, task creation flows, and synchronization logic across the app. The most significant changes include a more robust and user-friendly notification template handling, improved sync logic to avoid missing updates, and UI/UX enhancements for task and reminder management.

Notification and Reminder System Improvements:

  • Standardized the notification template shape and normalization logic in AddTaskModal.jsx, ensuring consistent handling and migration of legacy reminder templates. Now, default templates are normalized, and empty lists are respected as "no reminders."
  • Added support for passing default notification templates to the voice task panel, ensuring reminders are initialized consistently and only once per modal open. [1] [2]
  • Updated the logic for when reminders are enabled: reminders are now only set if the user is Plus and at least one template is present, preventing accidental scheduling of empty reminders.
  • Improved notification assignment logic in LocalNotificationScheduler.js by adding a shouldNotifyUser function, ensuring that notifications are only scheduled for the correct users based on assignment and circle membership. [1] [2]
  • Allowed consumers to specify a minimum number of notifications in NotificationTemplate, and improved the UI to prevent removing all notifications when not allowed. [1] [2] [3]

Synchronization Logic:

  • Refactored the SyncEngine to coalesce concurrent sync calls, ensuring that no updates are missed when multiple syncs are triggered in quick succession. This fixes issues where newly created tasks could vanish due to stale cursors. [1] [2] [3]

UI/UX Enhancements:

  • Updated the ChoreCard component to improve the layout and interaction for action buttons, including adding a visible "ThumbDown" action, adjusting button sizes, and removing the pending chip for a cleaner look. [1] [2] [3] [4] [5] [6] [7]
  • Passed the correct props and improved ordering for ChoreCard to ensure consistency and maintainability.
  • Added the NotificationPickerField to the voice task panel, making reminder selection available in voice-driven task creation. [1] [2]

Other Fixes and Cleanups:

  • Improved comments and removed unnecessary code in several places for clarity and maintainability, such as in NotificationTemplate.jsx and AddTaskModal.jsx. [1] [2]

Summary of Most Important Changes:

Notification and Reminder System:

  • Standardized and normalized reminder template handling, with migration for legacy templates and empty-list support.
  • Added logic to only enable reminders for Plus users with at least one template, preventing accidental scheduling.
  • Improved notification assignment logic to ensure only the correct users receive reminders. [1] [2]
  • Allowed configuration of minimum notifications and improved template UI to prevent invalid states. [1] [2] [3]

Synchronization:

  • Refactored sync logic to coalesce concurrent syncs, preventing missing updates and improving reliability. [1] [2] [3]

UI/UX:

  • Enhanced ChoreCard action buttons and layout, and integrated notification picker into voice task creation. [1] [2] [3] [4] [5]

meauxt added 3 commits August 3, 2026 01:56
…prevent lost writes

there is BUG that was very annoying cause by race condition we we update and sync happen as we update and doesn't return the latest added task. this basically fix it
@meauxt
meauxt merged commit 48dbc7a into develop Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant