Skip to content

Run PR integration jobs on engineering Windows agents - #3865

Merged
danroth27 merged 1 commit into
mainfrom
fix/pr-integration-engineering-pool
Sep 23, 2026
Merged

danroth27 merged 1 commit into
mainfrom
fix/pr-integration-engineering-pool

Conversation

@danroth27

Copy link
Copy Markdown
Member

Summary

  • Move PR CLI option coverage and scaffold integration jobs from Microsoft-hosted windows-latest to $(DncEngPublicBuildPool) with the same 1es-windows-2022-open image demand as the existing PR Windows build.
  • Add an optional pool-demand parameter to the shared integration job template. Official builds continue to use their existing internal pool and image; macOS stays on Microsoft-hosted agents.

Closes #3864. Follow-up to the pool discussion on #3862.

Validation

  • YAML parsing and structural checks confirmed that both integration jobs use the optional demand, PR routing matches the Windows build job, and the official pool defaults and macOS jobs are unchanged.
  • Azure Pipelines PR validation is needed to confirm agent scheduling and integration test results.

Route CLI option coverage and the scaffold integration matrix to the same public Windows image as the PR build jobs. Keep the official integration matrix on its internal image and leave hosted macOS unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2ff0cd05-fdd3-47bb-8b0c-983417c3829c
@danroth27
danroth27 requested a balanced review from Copilot September 23, 2026 19:36
@danroth27
danroth27 requested review from haileymck, mmitche, phenning and wtgodbe and removed request for haileymck September 23, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The routing matches the existing PR Windows build and leaves official defaults unchanged.

Review effort: Balanced
Findings: None

What changed in this PR

Routes PR integration workloads to the .NET engineering Windows pool while preserving official and macOS configurations.

Changes:

  • Adds optional pool demands to both shared integration jobs.
  • Routes PR integration jobs to DncEngPublicBuildPool with the Windows 2022 image demand.
File Description
eng/​pipelines/​scaffold-integration-matrix.yml Supports optional pool demands.
azure-pipelines-pr.yml Configures engineering Windows agents for integration jobs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@danroth27
danroth27 merged commit 04ce4df into main Sep 23, 2026
17 checks passed
@danroth27
danroth27 deleted the fix/pr-integration-engineering-pool branch September 23, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PR CLI coverage and integration jobs to the .NET engineering Windows pool

4 participants