Clarify when to apply Orleans ADO.NET migration scripts - #56247
Open
adarsh6980 wants to merge 1 commit into
Open
adarsh6980 wants to merge 1 commit into
adarsh6980 wants to merge 1 commit into
Conversation
Clarified migration script instructions for ADO.NET schema upgrades.
adarsh6980
requested review from
ReubenBond and
meaghanlewis
as code owners
September 24, 2026 11:31
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation-only changes are clear and address the stated issue.
Review effort: Lite
Findings: None
What changed in this PR
Clarifies when Orleans ADO.NET migration scripts are required, including setup failures caused by missing queries.
Changes:
- Documents the
Not all required queries founderror. - Explains schema and stored-query updates.
- Links clustering, persistence, and reminder migration scripts.
| File | Description |
|---|---|
docs/orleans/host/configuration-guide/adonet-configuration.md |
Expands ADO.NET migration guidance. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
gewarren
approved these changes
Sep 25, 2026
| The following sections contain links to SQL scripts for configuring your database and the corresponding ADO.NET invariant used to configure ADO.NET providers in Orleans. Customize these scripts as needed for your deployment. Before executing scripts for Clustering, Persistence, or Reminders, you need to create the main tables using the Main scripts. | ||
|
|
||
| If you are upgrading an existing ADO.NET schema, also apply the appropriate migration scripts for the providers you use: | ||
| If you are upgrading an existing ADO.NET schema, or if your setup fails with an error such as `System.ArgumentException: Not all required queries found`, also apply the appropriate migration scripts for the providers you use. These scripts bring the schema and stored queries up to date: |
Collaborator
There was a problem hiding this comment.
Suggested change
| If you are upgrading an existing ADO.NET schema, or if your setup fails with an error such as `System.ArgumentException: Not all required queries found`, also apply the appropriate migration scripts for the providers you use. These scripts bring the schema and stored queries up to date: | |
| If you're upgrading an existing ADO.NET schema, or if your setup fails with an error such as "System.ArgumentException: Not all required queries found", also apply the appropriate migration scripts for the providers you use. These scripts bring the schema and stored queries up to date: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38870.
The ADO.NET configuration doc mentioned the migration scripts only for upgrades. This makes clear they also apply when a setup fails with errors such as
System.ArgumentException: Not all required queries found, and points readers who hit that error at the scripts that bring the schema and stored queries up to date.Internal previews
Build report