Enable binlog capture for BuildWithComponents31 test#54863
Open
MichaelSimons wants to merge 1 commit into
Open
Enable binlog capture for BuildWithComponents31 test#54863MichaelSimons wants to merge 1 commit into
MichaelSimons wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a Razor integration test to run MSBuild via the AspNetSdkTest.ExecuteCommand() helper so MSBuild binlogs are captured automatically, improving diagnosability of intermittent CI failures related to legacy Razor compilation.
Changes:
- Switch
BuildWithComponents31IntegrationTestfrom directBuildCommand.Execute()toExecuteCommand(build)to enable automatic/bl:binlog capture.
Comment on lines
16
to
+17
| var build = new BuildCommand(projectDirectory); | ||
| build.Execute().Should().Pass(); | ||
| ExecuteCommand(build).Should().Pass(); |
MichaelSimons
force-pushed
the
michaelsimons/enable-binlog-rz10007-test
branch
from
3f49ddf to
c7522e7
Compare
Use ExecuteCommand() instead of direct Execute() so the base class adds /bl:msbuild0.binlog automatically. This will provide diagnostic data when the intermittent RZ10007 false positive occurs in CI. Relates to #54826 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MichaelSimons
force-pushed
the
michaelsimons/enable-binlog-rz10007-test
branch
from
c7522e7 to
d045afd
Compare
davidwengier
approved these changes
Jun 18, 2026
davidwengier
left a comment
davidwengier
left a comment
Member
There was a problem hiding this comment.
Approval does not imply acceptance of ownership of any of this code 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add diagnostic information for an intermittently failing test by switching from
build.Execute()toExecuteCommand(build), which automatically captures a binlog. SetWithWorkingDirectoryto the test asset's sandbox directory so the binlog is placed there rather than the shared test runner's current working directory.Context
This test is intermittently failing in CI on macOS arm64 with:
Related to #54826