Add ClickOnce manifest foundation - #1050
Open
dtivel wants to merge 7 commits into
Open
Conversation
10 tasks
dlemstra
reviewed
Aug 9, 2026
dtivel
force-pushed
the
dtivel/clickonce-manifest-foundation
branch
from
August 11, 2026 02:09
e0f67a1 to
7429d45
Compare
There was a problem hiding this comment.
Pull request overview
Adds dormant typed ClickOnce manifest infrastructure for signing algorithm version 2.
Changes:
- Adds typed readers, interfaces, and shared manifest adapters.
- Enforces SHA-256 metadata updates and serialization via
v4.5. - Packages required MSBuild runtime assemblies and adds comprehensive tests.
Show a summary per file
| File | Description |
|---|---|
Directory.Packages.props |
Pins compatible MSBuild manifest utilities. |
src/Sign.Core/Sign.Core.csproj |
Adds the manifest utilities dependency. |
ApplicationManifestAdapter.cs |
Adapts application manifests. |
ClickOnceManifestAdapter.cs |
Implements shared manifest operations. |
ClickOnceManifestReader.cs |
Reads typed ClickOnce manifests. |
DeployManifestAdapter.cs |
Adapts deployment manifests. |
IApplicationManifest.cs |
Defines the application-manifest contract. |
IClickOnceManifest.cs |
Defines common manifest operations. |
IClickOnceManifestReader.cs |
Defines typed reader operations. |
IDeployManifest.cs |
Defines the deployment-manifest contract. |
scripts/VerifyNuGetPackage.ps1 |
Verifies packaged MSBuild assemblies. |
ClickOnceManifestReaderTests.cs |
Covers reading, adapters, hashing, and serialization. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Balanced
dtivel
marked this pull request as draft
August 11, 2026 15:49
dtivel
marked this pull request as ready for review
August 12, 2026 00:40
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
Defer manifest-reader construction to conditional version 2 service registration, which already receives lazy singleton behavior from dependency injection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
Use the framework-aware ManifestUtilities writer and SHA-256 metadata updates through a shared adapter base. Strengthen the typed filesystem contract and adapter regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
dtivel
force-pushed
the
dtivel/clickonce-manifest-foundation
branch
from
August 12, 2026 00:40
7429d45 to
287a62b
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
Move shared assembly references and entry-point properties to the common manifest contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: be91288d-5106-4c59-a1fa-c5353dccb828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1049.
Summary
Add the dormant manifest foundation required by the ClickOnce signing algorithm version 2 specification.
ClickOnceManifestAdapter.IReadOnlyListfor resolution inputs andFileInfofor serialization destinations.v4.5behavior, preserving SHA-256 digest values and declarations.publisherIdentityand XML signature elements from the preserved XML before rewriting so regenerated signing metadata remains authoritative.The preservation behavior is format-neutral. This PR does not classify manifests as ClickOnce or VSTO and adds no technology-specific API.
Behavior
The new implementation is dormant:
Testing
DigestMethoddeclarations.