Skip to content

Fix invalid '--' inside XML comment in index.proj - #270

Merged
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:tannergooding-fix-index-proj-comment
Jul 19, 2026
Merged

Fix invalid '--' inside XML comment in index.proj#270
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:tannergooding-fix-index-proj-comment

Conversation

@tannergooding

Copy link
Copy Markdown
Member

The GenerateSubRepoTags comment added in #268 used a -- aside inside an XML comment, which MSBuild rejects with MSB4025 (an XML comment cannot contain --). This broke the index build:

index.proj(187,61): error MSB4025: The project file could not be loaded. An XML comment cannot contain '--', and '-' cannot be the last character.

Swapped the -- for a colon. No behavior change; the project now loads and parses cleanly.

The GenerateSubRepoTags comment used a '--' aside, which MSBuild rejects
with MSB4025 (an XML comment cannot contain '--').

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@jeffhandley jeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@tannergooding
tannergooding merged commit a6c45fc into dotnet:main Jul 19, 2026
2 checks passed
@tannergooding
tannergooding deleted the tannergooding-fix-index-proj-comment branch July 19, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants