Converge the SourceBrowser subtree: normalize EOL/BOM, unify package management, drop dead code - #275
Merged
tannergooding merged 5 commits intoJul 21, 2026
Conversation
…r subtree Adopt a .gitattributes matching the standalone SourceBrowser so the vendored subtree stops diverging purely on line endings and byte-order marks, then renormalize every text file to check-in LF (check-out native) with no BOM. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… subtree Add a subtree-root Directory.Packages.props so the sibling TestCode fixtures fall under central package management, move NuGetVersion into Directory.Build.props, drop the redundant per-reference MSBuild versions, prune unused package references, and target the test fixtures at net10.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Drop the unused Log.WaitForCompletion/OnCompleted plumbing, the no-op [HandleProcessCorruptedStateExceptions] (ignored on modern .NET), and unused using directives. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Only wire up the assembly-load and MSBuild-toolset dumps when SOURCEBROWSER_ASSEMBLY_DIAGNOSTICS=1 so normal indexing runs stay quiet, and reorder the usings and hoist GetTypeForwards to match the standalone layout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
GitGlyph targets net10.0 and does not reference app.config; its assembly binding redirects are ignored on modern .NET. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding
marked this pull request as ready for review
July 20, 2026 18:33
Member
Author
|
This is best reviewed with whitespace ignored. There was a lot of bad line-endings (not matching standard convention of check-in unix style, check-out host format) that were making diffs and ensuring source-indexer and sourcebrowser were in sync complex. The actual changes, ignoring the whitespace/bom, is small and trivial. |
jeffhandley
approved these changes
Jul 21, 2026
jeffhandley
left a comment
Member
There was a problem hiding this comment.
I reviewed commit-by-commit, which made this approachable. Looks nice and clean and this is a good modernization of the codebase.
tannergooding
deleted the
tannergooding-sourcebrowser-package-convergence
branch
July 21, 2026 18:52
Member
Author
|
Thanks. This should make it massively simpler to mirror things between now as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the divergence between the vendored
src/SourceBrowser/subtree and the standalone SourceBrowser so future porting/back-porting between them is trivial. No runtime behavior changes for indexing or serving; the subtree still builds and all tests pass (184 HtmlGenerator + 40 SourceIndexServer + 10 BinLogToSln).The changes are split into focused commits so the large mechanical normalization can be reviewed (or skipped) independently of the real edits.
Normalize line endings and BOMs
Adopts a
.gitattributesmatching the standalone repo (* text=auto,*.cmd eol=crlf, binary rules for png/ico/dll/snk) and renormalizes every text file to check-in LF / check-out native, no BOM. This is the bulk of the diff and is purely mechanical -- review with whitespace/EOL ignored.Converge package management
Directory.Packages.propsso the siblingTestCode/fixtures fall under central package management, matching the main projects.NuGetVersionintoDirectory.Build.propsinstead of hardcoding it per-project.PackageReferences fromMEFandGitGlyph.TestCodetest fixtures atnet10.0.Drop dead code
Log.WaitForCompletion/OnCompletedplumbing -- the flush-before-exit guarantee still lives inLog.Close()(CompleteAdding+Join), which is unchanged and called at every exit path.[HandleProcessCorruptedStateExceptions](ignored on modern .NET) and unusedusingdirectives.Quiet the default indexing run
HtmlGeneratorbehindSOURCEBROWSER_ASSEMBLY_DIAGNOSTICS=1so normal runs stay quiet, keeping the diagnostics available on demand.Remove dead config
GitGlyph/app.config;GitGlyphtargetsnet10.0and never references it, and its assembly binding redirects are ignored on modern .NET.