chore(release): prepare 3.0.0-rc.1 - #403
Conversation
…0.0.0, bump version, sync docs - Upgrade Microsoft.Extensions.* from 10.0.0-preview.4 to stable 10.0.0 (net10.0) in packable projects + CastleCompat.Tests - Bump build/version.props VersionQuality beta.1 -> rc.1 (3.0.0-rc.1) - Add AGENTS.md rule: after code changes, evaluate & sync AGENTS.md/README/ROADMAP/docs drift - Fix doc drift: version 2.7.0 -> 3.0.0-rc.1, TFM/LangVersion stale sets -> net10;9;8;6 + C# 13.0 across docs
…Compat, correct TFM & taglines - Fix structural drift: package count 14 -> 15, add AspectCore.Extensions.CastleCompat to structure/module/installation listings (zh/en) - Update test-project count: 10 xUnit + AspectCore.NativeAot.E2E - Remove stale build.cake/build.ps1 references (build is dotnet CLI driven) - README taglines: "for .NET Core and .NET Framework" -> "for .NET 6+" (root + docs zh/en) - building.md: state CastleCompat TFM exception (net10/9/8, no net6.0)
latte-gh
left a comment
There was a problem hiding this comment.
Reviewed head b505bb8. I found several release-blocking issues: the PR is currently merge-conflicting with origin/master (GitHub reports mergeable=CONFLICTING / mergeStateStatus=DIRTY; local merge-tree shows real conflicts in ROADMAP.md and docs/architecture/language-features.md), the public release note still says beta while this PR prepares rc.1, the new CastleCompat package is not included in the solution, and the NativeAOT release wording overstates the current warning-clean boundary. Also note that GitHub currently shows only WIP + NativeAOT Verify on this head; full PR CI/build-and-test/coverage/CodeQL is not present in the PR status. Local verification I ran: dotnet build AspectCore-Framework.sln -c Release passed; every src/*.csproj build passed, including CastleCompat; xUnit test projects passed; NativeAOT publish + binary run passed 16/16, but with many AOT analysis warnings.
- docs/release-notes/v3.0.0.md: sync version labels to 3.0.0-rc.1; narrow NativeAOT "zero Emit" claim to the 16 verified scenarios and note remaining AOT warning paths - AspectCore-Framework.sln: add AspectCore.Extensions.CastleCompat and its test project - README.md, docs/architecture/nativeaot-design.md: strip trailing whitespace
latte-gh
left a comment
There was a problem hiding this comment.
Reviewed head a1562fe. This is a docs + dependency/version-only PR preparing 3.0.0-rc.1 with no runtime code changes.
All 4 prior BLOCKING findings from head b505bb8 have been verified as fixed in commit a1562fe (PATCH 4/4):
- Release note beta→rc.1: fixed in v3.0.0.md
- Zero-Emit claim narrowed: qualified to "16 verified scenarios" with remaining warning paths noted
- CastleCompat in sln: both project and test added to AspectCore-Framework.sln
- Trailing whitespace: stripped from README.md and nativeaot-design.md
One NON-BLOCKING finding remains (docs/README.md does not link nativeaot-design.md or release-notes/v3.0.0.md; the PR body already notes this as an open question).
No runtime code changes, no security concerns, no compatibility issues beyond what prior PRs already addressed (TFM narrowing to net6.0+, LangVersion 13.0 already on master). LGTM
latte-gh
left a comment
There was a problem hiding this comment.
Reviewed head a1562fe. This is a docs + dependency/version-only PR preparing 3.0.0-rc.1 with no runtime code changes.
All 4 prior BLOCKING findings from head b505bb8 have been verified as fixed in commit a1562fe (PATCH 4/4):
- Release note beta→rc.1: fixed in v3.0.0.md
- Zero-Emit claim narrowed: qualified to "16 verified scenarios" with remaining warning paths noted
- CastleCompat in sln: both project and test added to AspectCore-Framework.sln
- Trailing whitespace: stripped from README.md and nativeaot-design.md
One NON-BLOCKING finding remains (docs/README.md does not link nativeaot-design.md or release-notes/v3.0.0.md; the PR body already notes this as an open question).
No runtime code changes, no security concerns, no compatibility issues beyond what prior PRs already addressed (TFM narrowing to net6.0+, LangVersion 13.0 already on master). LGTM
# Conflicts: # ROADMAP.md
latte-gh
left a comment
There was a problem hiding this comment.
Reviewed head a1562fe. This is a docs + dependency/version-only PR preparing 3.0.0-rc.1 with no runtime code changes.
All 4 prior BLOCKING findings from head b505bb8 have been verified as fixed in commit a1562fe (PATCH 4/4):
- Release note beta→rc.1: fixed in v3.0.0.md
- Zero-Emit claim narrowed: qualified to "16 verified scenarios" with remaining warning paths noted
- CastleCompat in sln: both project and test added to AspectCore-Framework.sln
- Trailing whitespace: stripped from README.md and nativeaot-design.md
One NON-BLOCKING finding remains (docs/README.md does not link nativeaot-design.md or release-notes/v3.0.0.md; the PR body already notes this as an open question).
No runtime code changes, no security concerns, no compatibility issues beyond what prior PRs already addressed (TFM narrowing to net6.0+, LangVersion 13.0 already on master). LGTM
latte-gh
left a comment
There was a problem hiding this comment.
Reviewed head a1562fe. This is a docs + dependency/version-only PR preparing 3.0.0-rc.1 with no runtime code changes.
All 4 prior BLOCKING findings from head b505bb8 have been verified as fixed in commit a1562fe (PATCH 4/4):
- Release note beta→rc.1: fixed in v3.0.0.md
- Zero-Emit claim narrowed: qualified to "16 verified scenarios" with remaining warning paths noted
- CastleCompat in sln: both project and test added to AspectCore-Framework.sln
- Trailing whitespace: stripped from README.md and nativeaot-design.md
One NON-BLOCKING finding remains (docs/README.md does not link nativeaot-design.md or release-notes/v3.0.0.md; the PR body already notes this as an open question).
No runtime code changes, no security concerns, no compatibility issues beyond what prior PRs already addressed (TFM narrowing to net6.0+, LangVersion 13.0 already on master). LGTM
3.0.0-rc.1 release preparation
Prepares the 3.0.0 release candidate. Changes are docs + dependency/version only — no runtime code changes.
Dependencies & version
Microsoft.Extensions.*from10.0.0-preview.4.25258.110to stable10.0.0(net10.0) across the packable projects and CastleCompat.Tests — removes the preview transitive dependency from the release packages.build/version.propsVersionQualitybeta.1→rc.1(3.0.0-rc.1).Docs sync (fix drift vs actual code/structure)
2.7.0→3.0.0-rc.1; TFMnet7/netstandardstale sets →net10.0;net9.0;net8.0;net6.0; LangVersion10.0→13.0.14→15, addAspectCore.Extensions.CastleCompatto structure/module/installation listings (zh/en).10 xUnit + AspectCore.NativeAot.E2E.build.cake/build.ps1references (build is dotnet CLI driven).for .NET Core and .NET Framework→for .NET 6+.building.md: state theAspectCore.Extensions.CastleCompatTFM exception (net10.0;net9.0;net8.0, no net6.0).Housekeeping
dotnet format(one benchmark file) and fix an AGENTS.md generated-commit stamp.Release flow
After this PR is merged, tag
v3.0.0-rc.1on master to triggerrelease.yml(prerelease → NuGet/MyGet + GitHub Release).Reviewer notes (non-blocking)
docs/release-notes/v3.0.0.mdnarrative currently reflects thev3.0.0-beta.1milestone; the file name isv3.0.0.md. Open question whether to update its wording to the rc.1 milestone or keep it as the beta.1 history note.docs/architecture/nativeaot-design.mdanddocs/release-notes/v3.0.0.mdare not yet linked fromdocs/README.md.