Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(adr-0013): hi-res needs an extraction rule, not a wider region #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(adr-0013): hi-res needs an extraction rule, not a wider region #321
Changes from all commits
37e488c90cbcaeFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define the Mesen2 row crop for
HiResEven.When Mesen2 emits a 512x478 frame, selecting even source rows produces 239 rows, not 224. This definition does not state which 224 rows remain or whether
FIRST_ROWandSCENE_Happly before or after decimation. Different hosts can therefore produce different canonical hashes.Specify the exact source-row window and indexing rule, then keep the host implementations and
build/scenes.tsvsemantics aligned.As per path instructions: docs are the specification, so the crop rule must be explicit here.
🤖 Prompt for AI Agents
Source: Path instructions
Uh oh!
There was an error while loading. Please reload this page.