Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: retract the Mode-5 defect claim — it is a 2-vs-2, not a RustySNES bug #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: retract the Mode-5 defect claim — it is a 2-vs-2, not a RustySNES bug #323
Changes from all commits
a0b2106File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Distinguish “no defect established” from “no defect exists.”
The 2-vs-2 result supports retaining the scene as contested, but
aresexplicitly marks the first-pixel initialization as unconfirmed on hardware.docs/adr/0013-accuracysnes-framebuffer-oracle.md#L228-L233: state that no RustySNES defect is established and no fix is justified pending hardware evidence.CHANGELOG.md#L29-L30: use the same unresolved-status wording.Proposed wording
As per path instructions, docs are the spec, so the status must preserve the documented uncertainty.
Based on learnings, a contested rendering is evidence to preserve, not proof of hardware truth.
📍 Affects 2 files
docs/adr/0013-accuracysnes-framebuffer-oracle.md#L228-L233(this comment)CHANGELOG.md#L29-L30🤖 Prompt for AI Agents
Sources: Path instructions, Learnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Scope the coverage statement to
C5.15.The earlier documentation keeps other Mode-5 scenes blocked because their reference renderings disagree. “The rest of Mode 5” can incorrectly imply that those scenes are now blessable.
docs/adr/0013-accuracysnes-framebuffer-oracle.md#L234-L237: refer to the remaining validated pixels ofC5.15.CHANGELOG.md#L31-L34: use the same scene-specific scope and retain the 57,120-pixel result as extraction validation.Proposed wording
As per path instructions, docs are the spec, so coverage claims must stay within the documented validated scope.
📍 Affects 2 files
docs/adr/0013-accuracysnes-framebuffer-oracle.md#L234-L237(this comment)CHANGELOG.md#L31-L34🤖 Prompt for AI Agents
Source: Path instructions
Uh oh!
There was an error while loading. Please reload this page.