[#3053] Suppressed 'docker compose cp' progress output in CI. - #3054
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (37)
📒 Files selected for processing (3)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. WalkthroughThe CI configurations add ChangesCI copy output
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🔵 Low · up to This PR changes CI command behavior by adding Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
==========================================
- Coverage 87.10% 86.98% -0.13%
==========================================
Files 101 100 -1
Lines 4917 4963 +46
Branches 47 3 -44
==========================================
+ Hits 4283 4317 +34
- Misses 634 646 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3053
Summary
Compose's progress writer prints two stderr lines per
docker compose cpinvocation - aCopying <src> to <dst>line and aCopiedconfirmation - and CI was leaving it on for every one of them. In theProvision sitestep, the twocpcalls that stagedb.sqlanddb2.sqlinto theclicontainer run first, so their four progress lines are the first thing printed in the step output, pushing the actual provisioning banner below the fold. The same chatter also heads theExport DB,Export built codebase,Process PHPUnit logs and coverage, andProcess test logs and artifactssteps.This adds a global
--progress quietflag to everydocker compose cpinvocation across both CI providers. The flag disables only Compose's progress writer - errors still reach stderr and exit codes are unchanged, verified against Compose v5.4.0, the version shipped indrevops/ci-runner:26.8.0.docker compose upkeeps its default progress output, since that output is worth keeping.Changes
Suppressed progress output on 'docker compose cp'
.github/workflows/build-test-deploy.ymlgains--progress quieton its 7docker compose cpinvocations, across theExport DB,Export built codebase,Provision site,Process PHPUnit logs and coverage, andProcess test logs and artifactssteps..circleci/config.ymlgains the same flag on its 8docker compose cpinvocations, across the equivalently namedExport DB,Export built codebase,Provision site,Process PHPUnit logs and coverage, andProcess test logs and artifactssteps..circleci/vortex-test-common.ymlis regenerated from.circleci/config.ymlviaahoy lint-ci-fix, carrying the same flag into the mirrored test job definition.Regenerated installer snapshot fixtures
ahoy update-snapshots, updating the_baselinefixture and the per-scenario.github/workflows/build-test-deploy.yml/.circleci/config.ymlfiles under.vortex/installer/tests/Fixtures/to match the source configuration changes above.Screenshots
N/A
Before / After
Summary by CodeRabbit