Skip to content

Replaced the provision task completion marker '<' with '+'. - #3061

Merged
AlexSkrypnyk merged 3 commits into
mainfrom
feature/provision-markers
Aug 21, 2026
Merged

Replaced the provision task completion marker '<' with '+'.#3061
AlexSkrypnyk merged 3 commits into
mainfrom
feature/provision-markers

Conversation

@AlexSkrypnyk

Copy link
Copy Markdown
Member

Summary

The five custom provision scripts in scripts/ share a block of output helpers, where task() opens a step by printing > and pass() closed it by printing <, so the closing marker read as a positive result only because it mirrored the opening one rather than stating anything on its own. This PR changes only the pass() line, replacing < with + across all five scripts, so the marker set becomes > opened, + succeeded, ! failed: three independent, self-explanatory meanings. The same files also define #;< TOKEN / #;> TOKEN installer fences, where < opens a block and > closes it, the exact inverse of the logger's prior orientation, so one file carried two contradictory conventions for the same pair of glyphs; dropping < from the logger ends that collision. < and > are additionally shell redirection operators, so they read as noise in a shell script's own output, and a leading > turns into a Markdown blockquote when a log is pasted into GitHub. + was chosen over the alternatives because it is the only printable ASCII character with an inherent positive charge that needs no partner glyph to be read correctly, and every shell script in this repository is deliberately ASCII-only, which ruled out a Unicode check mark.

Changes

  • Changed pass() in scripts/provision-00-enable-demo-modules.sh, scripts/provision-10-enable-dev-modules.sh, scripts/provision-20-migration.sh, scripts/provision-30-search-index.sh, and scripts/provision-40-example.sh to print + instead of < when a provisioning step completes.
  • Regenerated the 13 matching installer fixtures under .vortex/installer/tests/Fixtures/handler_process/ with ahoy update-snapshots so they stay byte-identical copies of the five scripts above.

Known follow-up

The recorded terminal demos .vortex/docs/static/img/build.json and provision.json (16 frames each) and their derived .svg/.png still show the old < marker. Re-recording them requires ahoy update-videos build provision, which .vortex/installer/CLAUDE.md gates behind explicit user permission, so that is left out of this PR.

Before / After

Marker vocabulary:

Marker Meaning Before After
> step opened yes yes
< step succeeded yes removed
+ step succeeded no yes
! step failed yes yes

Sample provisioning output, before:

   ==> Started demo modules operations.
       Environment: local
     > Creating the content model.
 [OK] Basic page applied successfully
     < Created the content model.
     > Setting site name.
     < Set site name.

Sample provisioning output, after:

   ==> Started demo modules operations.
       Environment: local
     > Creating the content model.
 [OK] Basic page applied successfully
     + Created the content model.
     > Setting site name.
     + Set site name.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 11 minutes

Limit details: You’ve used all 2 included reviews currently available. Your 82 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

You’re in a promotional period — use the checkbox below to run this review for free:

  • Run review for free

On-demand reviews are free for the next 31 days. After that, they cost $0.25 per reviewed file.

How can I continue?

Run this review now using the option above, or comment @coderabbitai review --use-credits.

You can also wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 46e8f6de-e02d-40f5-b1b8-1b5035b0fd66

📥 Commits

Reviewing files that changed from the base of the PR and between 3d557c5 and 94915a6.

⛔ Files ignored due to path filters (13)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-00-enable-demo-modules.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-10-enable-dev-modules.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-30-search-index.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-40-example.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/scripts/provision-20-migration.sh is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (5)
  • scripts/provision-00-enable-demo-modules.sh
  • scripts/provision-10-enable-dev-modules.sh
  • scripts/provision-20-migration.sh
  • scripts/provision-30-search-index.sh
  • scripts/provision-40-example.sh

Comment @coderabbitai help to get the list of available commands.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk
AlexSkrypnyk enabled auto-merge (squash) August 21, 2026 00:46
@AlexSkrypnyk AlexSkrypnyk added this to the 1.41.0 milestone Aug 21, 2026
@AlexSkrypnyk AlexSkrypnyk added the AUTOMERGE Pull request has been approved and set to automerge label Aug 21, 2026
@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

This comment has been minimized.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.66%. Comparing base (3d557c5) to head (94915a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
- Coverage   87.08%   86.66%   -0.43%     
==========================================
  Files         106       99       -7     
  Lines        4994     4813     -181     
  Branches       58        3      -55     
==========================================
- Hits         4349     4171     -178     
+ Misses        645      642       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6a87a5798c1430133962b1cf--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.56% (206/209)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.56% (206/209)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
AlexSkrypnyk disabled auto-merge August 21, 2026 05:36
@AlexSkrypnyk
AlexSkrypnyk merged commit 16d1a28 into main Aug 21, 2026
35 of 36 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/provision-markers branch August 21, 2026 05:36
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AUTOMERGE Pull request has been approved and set to automerge

Projects

Status: Released in 1.41.0

Development

Successfully merging this pull request may close these issues.

1 participant