Replaced the provision task completion marker '<' with '+'. - #3061
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Limit details: You’ve used all 2 included reviews currently available. Your 82 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. You’re in a promotional period — use the checkbox below to run this review for free:
On-demand reviews are free for the next 31 days. After that, they cost $0.25 per reviewed file. How can I continue?Run this review now using the option above, or comment You can also wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (5)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
- Coverage 87.08% 86.66% -0.43%
==========================================
Files 106 99 -7
Lines 4994 4813 -181
Branches 58 3 -55
==========================================
- Hits 4349 4171 -178
+ Misses 645 642 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a87a5798c1430133962b1cf--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Summary
The five custom provision scripts in
scripts/share a block of output helpers, wheretask()opens a step by printing>andpass()closed it by printing<, so the closing marker read as a positive result only because it mirrored the opening one rather than stating anything on its own. This PR changes only thepass()line, replacing<with+across all five scripts, so the marker set becomes>opened,+succeeded,!failed: three independent, self-explanatory meanings. The same files also define#;< TOKEN/#;> TOKENinstaller fences, where<opens a block and>closes it, the exact inverse of the logger's prior orientation, so one file carried two contradictory conventions for the same pair of glyphs; dropping<from the logger ends that collision.<and>are additionally shell redirection operators, so they read as noise in a shell script's own output, and a leading>turns into a Markdown blockquote when a log is pasted into GitHub.+was chosen over the alternatives because it is the only printable ASCII character with an inherent positive charge that needs no partner glyph to be read correctly, and every shell script in this repository is deliberately ASCII-only, which ruled out a Unicode check mark.Changes
pass()inscripts/provision-00-enable-demo-modules.sh,scripts/provision-10-enable-dev-modules.sh,scripts/provision-20-migration.sh,scripts/provision-30-search-index.sh, andscripts/provision-40-example.shto print+instead of<when a provisioning step completes..vortex/installer/tests/Fixtures/handler_process/withahoy update-snapshotsso they stay byte-identical copies of the five scripts above.Known follow-up
The recorded terminal demos
.vortex/docs/static/img/build.jsonandprovision.json(16 frames each) and their derived.svg/.pngstill show the old<marker. Re-recording them requiresahoy update-videos build provision, which.vortex/installer/CLAUDE.mdgates behind explicit user permission, so that is left out of this PR.Before / After
Marker vocabulary:
><+!Sample provisioning output, before:
Sample provisioning output, after: