Forward-ported 42 commits from 'main' onto '2.x'. - #3072
Merged
Conversation
…ered in. Forward-ported from main 7326192. Re-implemented in the PHP tooling rewrite; BATS coverage replaced with PHPUnit.
| datasource | package | from | to | | ----------- | ---------------------------- | ------ | ------ | | github-tags | toshimaru/auto-author-assign | v3.0.3 | v3.1.0 | (cherry picked from commit 7b6cdaf)
(cherry picked from commit 1ffc2e8) Kept the 2.x 'subtestSolr()' name; fixtures regenerated separately.
(cherry picked from commit bee1d7e) Bumped 'drevops/behat-steps' to '^3.13.0' so the added traits resolve; fixtures regenerated separately.
(cherry picked from commit f8f5cd5) Fixtures regenerated separately.
…ts to 80. (cherry picked from commit 37954ee) Kept the 2.x counter data attributes and theme behavior; reflowed the affected test lines. Fixtures regenerated separately.
(cherry picked from commit 3e6a29c) Dropped the 'RemoveUnusedPublicMethodParameterRector' skip and its 'Theme' handler line: 2.x ships no 'src/Hook' classes. Applied to the CLI config in place of the installer one.
Forward-ported from main be036fc. Re-implemented in the PHP tooling rewrite; read the variable with 'getenv()' so an empty value still disables the option.
Forward-ported from main 852fdf1. Dropped the tooling-script publication: those scripts are PHP on this line and Shellvar reads only shell, so the tooling directory is no longer passed as an input.
…' literally. (cherry picked from commit a793ce5) Dropped the generated variables table hunk: it documents a variable this line does not carry.
…y step. Forward-ported from main 16fad83. Re-implemented against the deploy step that replaced 'scripts/provision-10-enable-dev-modules.sh'; dropped the installer-side script removal, which has no counterpart here.
(cherry picked from commit 53c6b75) Reapplied the CircleCI step reorder by hand against the folded job set; fixtures regenerated separately.
…nce page. (cherry picked from commit 7184b05) Restored this line's facts in the merged tables: the 'deploy_steps' requirement, the CLI in place of the installer, and the deploy steps in place of the removed provision scripts.
Forward-ported from main 3ef3c76. Re-implemented in 'MigrateContentDeployStep', which replaced 'scripts/provision-20-migration.sh'; dropped the shell output-helper guidance, which has no counterpart in the PHP tooling.
…uild jobs. (cherry picked from commit c0c2aaa) Removes the toolchains directly rather than through a bind-mounting container, because these jobs run on the runner rather than inside one. Named the variable 'VORTEX_CI_FREE_DISK_SPACE' to match the prefix already used here, and targeted the 'test' job that absorbed the separate 'database' job.
Forward-ported from main 44a2acc. Pinned the example at the '2.0' series this line ships rather than main's '1.4'.
(cherry picked from commit 93d422e) Fixtures regenerated separately.
…class instead of the object. Forward-ported from main 6ddee19. Ported the template fix only: the added harness unit tests cover traits that do not exist under '.vortex/tests' on this line.
…' 2.6.0. (cherry picked from commit d19ec22) Bumped 'drevops/behat-screenshot' from '^2.4.2' rather than main's '^2.5.0'; fixtures regenerated separately.
…RUNNER' roles. (cherry picked from commit 01e6ccb) Declared the roles on the job's own env rather than main's container executor, which this line does not use, and named them with the 'VORTEX_CI_' prefix already in use here. Fixtures regenerated separately.
… facts across all sections. (cherry picked from commit dd5b0ac) Kept this line's facts wherever main corrected its own: the CLI, PHP tooling, deploy steps, the environment detector and the runner-less CI. Rewrote the added tooling page for the PHP scripts and PHPUnit, repaired the auto-merged BATS sections in the template page, and dropped the parallelism page, which duplicates the section already in the CI overview.
…raits into 'FeatureContext'. (cherry picked from commit 70714d3) Fixtures regenerated separately.
…from the runner index. (cherry picked from commit 66f481d) Named with the 'VORTEX_CI_' prefix used here, and documented in the CI overview, where this line keeps the parallelism section. Fixtures regenerated separately.
(cherry picked from commit 7f8d044) Left the re-recorded 'test-bdd' assets out: the recordings belong to the other line and are re-recorded here.
…th per-topic subsections and canonical tool pages. (cherry picked from commit 645b0b6) Adopted the new information architecture while keeping this line's facts throughout: the CLI, deploy steps in place of provision scripts, the PHP tooling, the environment detector and the prefixed CI variables. Re-homed the deploy step example beside its page and repointed every link the move broke. The added doctor and info recordings come from the other line and need re-recording here.
…build. (cherry picked from commit 180a09c)
(cherry picked from commit 438b557) Reduced to the documentation and 'behat.yml' comments: the CI configurations here already declare these variables with the prefix. Also corrected the job names the moved pages inherited.
(cherry picked from commit d112264) Dropped the installer test hunk: that suite does not exist here. Fixtures regenerated separately.
…ompilation. (cherry picked from commit 68f0a65) Kept this line's longer functional-test timeouts and its CI runner PHP checklist item. Fixtures regenerated separately.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Set the demo page body only when the bundle carries the field, so generating content does not abort on an install profile with a different content model. Restored the YAML comment marker in the update tests, where the flat ESLint config rename had also rewritten the 'docker-compose.yml' markers.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Adds 'VORTEX_CI_FREE_DISK_SPACE' and reflows the table, whose column widths changed once the tooling directory stopped being a Shellvar input.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ed site. A page pulls a shipped file in with a path that resolves against the checkout the build runs in, so a file only one major ships could not be found when the site was assembled from the other. Each major's targets are now extracted from its own ref. Also removed a duplicate import and repaired two links the restructure broke.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a952c9f5e010a715b75620c--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-ports 42 commits from
mainonto2.x, the first pass since the August run.mainand2.xhave diverged substantially -2.xreplaced the installer with a multi-verb CLI, rewrote the shipped tooling from Bash to PHP, replaced thescripts/provision-*.shchain withdeploy_stepsplugins, dropped thedrevops/ci-runnercontainer executor, and moved environment detection intodrevops/environment-detector. Most commits therefore needed adaptation rather than a clean cherry-pick, and every port keeps this line's architecture and facts.git cherrylists 167 commits onmainthat are not patch-present on2.x. 114 of those were settled in earlier propagation runs, leaving 53 undecided: 42 are applied here and 11 are deliberately excluded and listed below.Applied
Bug fixes
732619293Restored the Lagoon database override flag to the state it was discovered in - adapted: re-implemented in the PHP rewrite, BATS coverage replaced with PHPUnit.93d422ed4Anchored environment variable prefixes forwarded byahoy cli- clean cherry-pick.6ddee19e0FixedgetProtectedValue()reading the property from the reflection class instead of the object - adapted: template fix only.180a09cf4Fixedwindow.gtag is not a functionin the docs dev server after a build - clean cherry-pick.d1122642eTracked.claude/skills/in consumer projects by default - adapted: dropped the installer test hunk.Provisioning and deploy steps
1ffc2e85cRaised the InnoDB redo log capacity so large database dumps import - adapted: kept the localsubtestSolr()name.f8f5cd516Raised the default Drushmemory_limitto 1G - clean cherry-pick.be036fc30Excluded cache table data from the exported database dump - adapted: re-implemented in PHP,getenv()so an empty value disables it.16fad832fAdded generated content provisioning to the development modules deploy step - adapted: re-implemented inEnableDevelopmentModulesDeployStep.3ef3c7677Disabled the Solr search server while migrations run - adapted: re-implemented inMigrateContentDeployStep.44a2acc27Required a~version constraint when installing the tooling package - adapted: pinned at the 2.0 series.Continuous integration
53c6b7508Rancomposer auditfirst and every audit check regardless of failures - adapted: CircleCI reorder reapplied against the folded job set.c0c2aaa1cFreed preinstalled runner toolchains in the GitHub Actions test and build jobs - adapted: direct removal, jobs are not containerised here.90a02b360Migrated release drafter's default version resolver to a version-resolver category - clean cherry-pick.01e6ccb15Replaced per-step CI runner conditions with declaredVORTEX_CI_IS_*_RUNNERroles - adapted: declared on the job env, prefixed.438b557e0Renamed unprefixedCI_*variables toVORTEX_CI_*- adapted: reduced to docs and behat.yml, configs already prefixed.6ab64210fReplacedsuspend_mail_sendwith a mail collector and a closed mail transport in CI - adapted: used the environment detector constant, kept the reroute-email guard.97b2b9b1cSuppresseddocker compose cpprogress output in CI - adapted: applied to every call site.Behat and testing
bee1d7e22Wired the remainingbehat-stepstraits intoFeatureContext- adapted: bumped behat-steps so the traits resolve.d19ec229fSkipped Behat animated screenshots in CI onbehat-screenshot2.6.0 - adapted: bumped from a lower constraint.70714d35eUpdated template Composer dependencies and wired ninebehat-stepstraits intoFeatureContext- adapted: resolved to the newer constraints.66f481d68AddedVORTEX_CI_BEHAT_PROFILE_OFFSETto decouple the Behat profile from the runner index - adapted: prefixed, documented in the CI overview.7f8d04442Updateddrevops/behat-stepsto 3.14.1 - adapted: constraint only.Front-end toolchain
37954ee98Raised the PrettierprintWidthdefault to 160 and pinned doc comments to 80 - adapted: kept the local counter data attributes and theme behavior.3e6a29c1cCompleted the Rector rename-skip family and audited the skip list - adapted: dropped the Hook-scoped skip, nosrc/Hookclasses here.68f0a6510Switched the template from Yarn to npm for module scripts and theme compilation - adapted: kept the local test timeouts and CI runner PHP checklist item.dd3e1372aAdopted the Drupal core ESLint 9 configuration and updated the front-end toolchain - adapted: CLI property name, took the jQuery-free theme behavior.ca0ca82f7Synchronised npm lock files when the CLI removes front-end tools - adapted: new utility placed under the CLI namespace.Documentation
852fdf1feAsserted that every documentation variable source yields variables - adapted: dropped the tooling-script publication, Shellvar reads only shell.a793ce58aDisabled JetBrains Mono ligatures - adapted: CSS only.7184b0524Refreshed the contrib module documentation and added a Modules reference page - adapted: restored thedeploy_stepsrow, the CLI, and the deploy steps.dd5b0ac07Reconciled the Vortex documentation for coherence and corrected stale facts - adapted: kept this line's facts, rewrote the tooling page for PHP/PHPUnit.645b0b6f2Restructured the documentation into a single Development section - adapted: adopted the IA, kept this line's facts, repointed broken links.3d557c5fdRecorded the demos at a 10:6 screen ratio and sized the home page to them - adapted: recorder and home page only.10eabe71eServed both documentation majors from one combined site built on every branch - adapted: kept the build-cli target.4f30e8646Refused to render a demo video whose recorded output reports an issue - adapted: kept the cli-install name.Dependencies and images
7b6cdaf78Update toshimaru/auto-author-assign action to v3.1.0 - clean cherry-pick.c8559df24Update Container images to v26.8.1 - clean cherry-pick.800617651Update uselagoon/mysql-8.4 to v26.8.1 - adapted: also converted the two extra local guards.9e9c46d8eUpdate PHP packages except core - clean cherry-pick.c0bf95495Update dawidd6/action-download-artifact to v24 - adapted: pin set directly, was at v21.1c0ae9fa4Update uselagoon/valkey-8 to v26.8.1 - adapted: kept the local service name and token.Skipped
e8451d3bReplaced versioned Drupal Rector sets with the composer-based set - already present;rector.phphere already usesDrupalSetProviderwithwithComposerBased().9df36c9fRemoved unmodified template-owned paths the install no longer ships - the entire payload is.vortex/installer/**, which does not exist on this line.95ada7a8Closed everytaskwith apassor afailin shipped scripts - the PHPTASK()helper takes both a start and a finish message, so it closes by construction; the BATS tests it patched do not exist here.32be59ccInstalledtestmodefrom the development modules provision script - effectively present;ys_demodeclarestestmodeas a dependency and configures it inys_demo.deploy.php.e899e9ecUpdate dawidd6/action-download-artifact to v23 - superseded by the v24 bump in this PR.55b7e24fPrepared the 1.41.0 release - release bookkeeping for the other line; pins the tooling to a 1.x version where this line requires^2.0@alpha.4122e731Re-recorded the demo videos and updated dependencies - the recordings belong to the other line and are re-recorded here.cc7f3c8fRefreshed template and.vortex/dependencies - touches.vortex/installerlock files; this line refreshes its own through theupdate-vortex-dev-depsskill.8cf24175Made recorded terminal demos reproducible - reverted onmainby3d87e56f; the revert was verified complete, so the pair nets to nothing.3d87e56fRevert "Made recorded terminal demos reproducible" - the revert of a skipped commit.16d1a28fReplaced the provision task completion marker<with+- touches onlyscripts/provision-*.sh, none of which exist on this line.Snapshots
ahoy update-snapshotswas run from.vortex/and has converged: 150 of 150 scenarios pass with 0 updates on a repeat run. Several follow-up fixes were needed to get there and are included as their own commits: a duplicatedSSMTP_MAILHUBentry in the Docker Compose fixtures, stale ESLint 8 entries in the Acquia snapshot diffs, and the regenerated fixtures for the Prettier reflow and the generated-content guard.No shipped template file was deleted in a way that leaves a stale
SutTrait.phpassertion: the one deletion that mattered,ys_base.module, had its assertion removed in the same commit.The generated variables table was regenerated with
ahoy update-docs. Its only substantive change is the newVORTEX_CI_FREE_DISK_SPACErow; the rest is a reflow, because dropping the tooling directory as a Shellvar input changed the table's column widths.Gates
ahoy lintpasses from.vortex/- PHPCS, PHPStan, Rector, shell and Dockerfile linters, docs spellcheck, markdownlint, and the generated CircleCI config check.ahoy test-toolingpasses with 808 tests and 3843 assertions..circleci/vortex-test-common.ymlwas regenerated withphp .vortex/tests/generate-vortex-dev-circleci.The documentation builds standalone and as the combined two-major site, and its lint, spellcheck and 196 unit tests pass.
CI is green across all 38 checks, including every
vortex-test-workflowleg, bothvortex-test-climatrix jobs, both providers' lint and test jobs, and the documentation workflow.Notes for review
mainreconciled and then restructured its docs against its own architecture, so its side of nearly every conflict describes the installer, the shell tooling, the provision scripts and thedrevops/ci-runnercontainer. This line's facts were kept throughout, the new maintenance page for the tooling package was rewritten for PHP and PHPUnit, and every link the restructure broke was repointed.VORTEX_CI_IS_*_RUNNERrather thanCI_IS_*, because this line already prefixes its CI variables. That makes the later rename commit a near no-op here.doctor,doctor-infoandinfodemo recordings came across from the other line and should be re-recorded here withahoy update-videos.bodyfield on itspagetype, so the demo plugin sets that field only when the bundle carries it - the same guard it already applied tomoderation_state. Separately, a page pulls a shipped file in with a path that resolves against the checkout the build runs in, so assembling the combined site from this line could not find a file only the other major ships; each major's targets are now read from its own ref.Before / After