Skip to content

Suppressed the 'git init' branch advice leaking into the installer output. #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 2 commits into from
Aug 31, 2026
+13 −2
Merged

Suppressed the 'git init' branch advice leaking into the installer output. #3074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42a7ec7
Suppressed the 'git init' initial branch advice in the installer output.
AlexSkrypnyk Aug 31, 2026
4368e34
Replaced the 'update-videos.php' fatal error with a message and exit …
AlexSkrypnyk Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .vortex/docs/.utils/update-videos.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,13 @@ function main(array $argv): int {
return 0;
}

exit(main($argv));
// A failure inside main() reports itself before it is thrown, so the message
// alone is the whole error.
try {
exit(main($argv));
}
catch (Throwable $exception) {
fwrite(STDERR, $exception->getMessage() . "\n");

exit(1);
}
4 changes: 3 additions & 1 deletion .vortex/installer/src/Utils/FileManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ public function prepareDestination(): array {

// The destination arrives from a CLI option, the environment or a config
// file, so it is escaped rather than interpolated into the shell string.
$command = sprintf('git --work-tree=%s --git-dir=%s init > /dev/null', escapeshellarg($destination), escapeshellarg($destination . '/.git'));
// 'git init' writes the initial branch advice to stderr when
// 'init.defaultBranch' is unset, and passthru() draws it inside the TUI.
$command = sprintf('git -c advice.defaultBranchName=false --work-tree=%s --git-dir=%s init > /dev/null', escapeshellarg($destination), escapeshellarg($destination . '/.git'));
passthru($command, $exit_code);

if ($exit_code !== 0 || !File::exists($destination . '/.git')) {
Expand Down