[#3077] Covered '.mjs' and '.cjs' by the '.editorconfig' line-length rule and removed the redundant 'eslint.config.mjs' section. - #3083
Conversation
…rule and removed the redundant 'eslint.config.mjs' section.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. WalkthroughThe ChangesEditorConfig pattern update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to JavaScript, MJS, and CJS files now share the intended line-length setting, with the redundant MJS-specific override removed. No current merge-readiness risk is identified. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The reviewable changes satisfy the .mjs and .cjs coverage requirements and remove the redundant configuration section. Synchronization of the installer baseline fixture cannot be verified because .vortex/installer/tests/Fixtures/handler_process/_baseline/.editorconfig was excluded by the !.vortex/installer/tests/Fixtures/** path filter. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
==========================================
- Coverage 87.36% 87.00% -0.36%
==========================================
Files 107 100 -7
Lines 5088 4925 -163
Branches 49 3 -46
==========================================
- Hits 4445 4285 -160
+ Misses 643 640 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a9904612a258357eb91ba8f--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Closes #3077
Summary
The
[eslint.config.mjs]section in.editorconfigbecame a no-op after the 1.41.0 rename from[.eslintrc.json], because itsindent_size = 2is already inherited from[*]and.mjsmatches no more specific glob than[*]itself. At the same time,.mjsand.cjsfiles fell outside themax_line_length = 160rule that mirrors Prettier'sprintWidth, since they matched neither[*.js]nor[*.{json,lock}]. This PR widens the JavaScript glob to[*.{js,mjs,cjs}]so the line-length rule applies uniformly, and removes the now-redundant[eslint.config.mjs]section.Changes
[*.js]section in root.editorconfigto[*.{js,mjs,cjs}]somax_line_length = 160also applies to.mjsand.cjsfiles.[eslint.config.mjs]section from root.editorconfig, since itsindent_size = 2was already inherited from[*]..vortex/installer/tests/Fixtures/handler_process/_baseline/.editorconfigvia the snapshots tooling to match the updated root file..editorconfigexists underweb/, so the root file is the only one affected by this change.Before / After
Summary by CodeRabbit