Skip to content

[#3082] Excluded 'sdc_devel' from exported configuration like the other development modules. #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 5 commits into from
Sep 3, 2026
Merged

[#3082] Excluded 'sdc_devel' from exported configuration like the other development modules. #3088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1390ef7
[#3082] Excluded 'sdc_devel' from exported configuration like the oth…
AlexSkrypnyk Sep 3, 2026
c33470b
Updated snapshots.
AlexSkrypnyk Sep 3, 2026
92855f0
[#3082] Added config export assertions for development module exclusi…
AlexSkrypnyk Sep 3, 2026
b940762
[#3082] Used the renamed 'sw_' custom module names in the config expo…
AlexSkrypnyk Sep 3, 2026
3bae013
Addressed code review: made the enabled development module checks mat…
AlexSkrypnyk Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vortex/docs/content/development/modules/contributed-modules.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ email rerouting in an environment where it would otherwise be enabled.

### Configuration

No settings override.
[`settings.sdc_devel.php`](https://github.com/drevops/vortex/blob/main/web/sites/default/includes/modules/settings.sdc_devel.php) excludes it from the exported configuration.

## Search API

Expand Down
5 changes: 5 additions & 0 deletions ...tests/Fixtures/handler_process/_baseline/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public function testEnvironmentNoOverrides(): void {
$settings['config_exclude_modules'] = [
'devel',
'generated_content',
'sdc_devel',
'testmode',
];
$settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -171,6 +172,7 @@ public function testEnvironmentOverrides(): void {
$settings['config_exclude_modules'] = [
'devel',
'generated_content',
'sdc_devel',
'testmode',
];
$settings['config_sync_directory'] = 'custom_config';
Expand Down Expand Up @@ -227,6 +229,7 @@ public function testEnvironmentLocal(): void {
$settings['config_exclude_modules'] = [
'devel',
'generated_content',
'sdc_devel',
'testmode',
];
$settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -283,6 +286,7 @@ public function testEnvironmentLocalContainer(): void {
$settings['config_exclude_modules'] = [
'devel',
'generated_content',
'sdc_devel',
'testmode',
];
$settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -382,6 +386,7 @@ public function testEnvironmentGha(): void {
$settings['config_exclude_modules'] = [
'devel',
'generated_content',
'sdc_devel',
'testmode',
];
$settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down
10 changes: 10 additions & 0 deletions ...tures/handler_process/_baseline/web/sites/default/includes/modules/settings.sdc_devel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

/**
* @file
* SDC Devel settings.
*/

declare(strict_types=1);

$settings['config_exclude_modules'][] = 'sdc_devel';
2 changes: 1 addition & 1 deletion ...ures/handler_process/ciprovider_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
2 changes: 1 addition & 1 deletion .../code_coverage_provider_codecov_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...andler_process/deploy_types_all_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...ndler_process/deploy_types_none_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...rocess/deps_updates_provider_ci_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
10 changes: 10 additions & 0 deletions ...dler_process/hosting_acquia/docroot/sites/default/includes/modules/settings.sdc_devel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

/**
* @file
* SDC Devel settings.
*/

declare(strict_types=1);

$settings['config_exclude_modules'][] = 'sdc_devel';
8 changes: 7 additions & 1 deletion .../Fixtures/handler_process/hosting_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}

/**
@@ -398,6 +442,325 @@
@@ -403,6 +447,331 @@
$settings['maintenance_theme'] = 'claro';
$settings['skip_permissions_hardening'] = TRUE;
$settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -90,6 +90,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -142,6 +143,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -194,6 +196,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -243,6 +246,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -296,6 +300,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = 'custom_acquia_config';
Expand Down Expand Up @@ -356,6 +361,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '/var/www/site-php/mysite/config';
Expand Down
Empty file added ...handler_process/hosting_acquia/web/sites/default/includes/modules/-settings.sdc_devel.php
View file
Open in desktop
Empty file.
6 changes: 5 additions & 1 deletion .../Fixtures/handler_process/hosting_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
}

/**
@@ -402,6 +582,279 @@
@@ -407,6 +587,283 @@
'^localhost$',
];
$this->assertSettings($settings);
Expand Down Expand Up @@ -227,6 +227,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -290,6 +291,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -353,6 +355,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -414,6 +417,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down
10 changes: 10 additions & 0 deletions ...sting_project_name___acquia/docroot/sites/default/includes/modules/settings.sdc_devel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

/**
* @file
* SDC Devel settings.
*/

declare(strict_types=1);

$settings['config_exclude_modules'][] = 'sdc_devel';
8 changes: 7 additions & 1 deletion ...er_process/hosting_project_name___acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
}

/**
@@ -398,6 +442,325 @@
@@ -403,6 +447,331 @@
$settings['maintenance_theme'] = 'claro';
$settings['skip_permissions_hardening'] = TRUE;
$settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -90,6 +90,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -142,6 +143,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -194,6 +196,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -243,6 +246,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['container_yamls'][0] = $this->app_root . '/' . $this->site_path . '/services.yml';
Expand Down Expand Up @@ -296,6 +300,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = 'custom_acquia_config';
Expand Down Expand Up @@ -356,6 +361,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '/var/www/site-php/mysite/config';
Expand Down
Empty file added .../hosting_project_name___acquia/web/sites/default/includes/modules/-settings.sdc_devel.php
View file
Open in desktop
Empty file.
6 changes: 5 additions & 1 deletion ...er_process/hosting_project_name___lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
}

/**
@@ -402,6 +582,279 @@
@@ -407,6 +587,283 @@
'^localhost$',
];
$this->assertSettings($settings);
Expand Down Expand Up @@ -227,6 +227,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -290,6 +291,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -353,6 +355,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -414,6 +417,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down
2 changes: 1 addition & 1 deletion ...dler_process/migration_disabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -348,9 +348,9 @@
@@ -352,9 +352,9 @@
}

/**
Expand Down
6 changes: 5 additions & 1 deletion ...andler_process/migration_disabled_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
}

/**
@@ -402,6 +582,279 @@
@@ -407,6 +587,283 @@
'^localhost$',
];
$this->assertSettings($settings);
Expand Down Expand Up @@ -227,6 +227,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -290,6 +291,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -353,6 +355,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down Expand Up @@ -414,6 +417,7 @@
+ $settings['config_exclude_modules'] = [
+ 'devel',
+ 'generated_content',
+ 'sdc_devel',
+ 'testmode',
+ ];
+ $settings['config_sync_directory'] = '../config/default';
Expand Down
2 changes: 1 addition & 1 deletion ...xtures/handler_process/migration_enabled/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -148,6 +148,13 @@
@@ -149,6 +149,13 @@
$databases['default']['default']['collation'] = 'utf8_general_ci';
$databases['default']['default']['driver'] = 'mysql';
$databases['default']['default']['prefix'] = '';
Expand Down
4 changes: 2 additions & 2 deletions ...ndler_process/migration_enabled_circleci/tests/phpunit/Drupal/EnvironmentSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -148,6 +148,13 @@
@@ -149,6 +149,13 @@
$databases['default']['default']['collation'] = 'utf8_general_ci';
$databases['default']['default']['driver'] = 'mysql';
$databases['default']['default']['prefix'] = '';
Expand All @@ -12,7 +12,7 @@
$this->assertEquals($databases, $this->databases);

// Verify key config overrides.
@@ -348,9 +355,9 @@
@@ -352,9 +359,9 @@
}

/**
Expand Down
Loading