fix(ostool): tolerate closed serial bridge consumer#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
tgoskits的 Starry self-hosted board CI 在ostool 0.23更新后,可能在 success matcher 已经命中之后仍然因为 serial bridge 清理阶段的本地BrokenPipe报错而失败。典型日志是:成功输出已经出现,但随后 runner 报failed to write serial websocket bytes: broken pipe。修改
write_bridge_bytes。write_all或flush返回BrokenPipe时,将其视为本地终端已经结束读取,正常退出 reader task。验证
cargo fmt --allcargo fmt --all -- --checkcargo test -p ostool serial_stream -- --nocapturecargo test -p ostool -- --nocapturecargo test -p ostool --all-features -- --nocapturecargo clippy -p ostool --all-targets --all-features -- -D warningscargo build --target x86_64-unknown-linux-gnu --all-featurescargo clippy --target x86_64-unknown-linux-gnu --all-featurescargo test --target x86_64-unknown-linux-gnu --all-features -- --nocapture未做真实硬件板卡验证;本 PR 只修复 ostool 本地 serial bridge 关闭路径。