Skip to content

Documentation page describing data sources.#65

Open
elainethale wants to merge 1 commit into
mainfrom
feat/basic-data-source-docs
Open

Documentation page describing data sources.#65
elainethale wants to merge 1 commit into
mainfrom
feat/basic-data-source-docs

Conversation

@elainethale
Copy link
Copy Markdown
Contributor

No description provided.

@elainethale elainethale requested a review from daniel-thom May 8, 2026 16:36
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.55%. Comparing base (ded9c7f) to head (eed12a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files          50       50           
  Lines        7935     7935           
=======================================
  Hits         5995     5995           
  Misses       1940     1940           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elainethale elainethale requested a review from irmatgit May 20, 2026 15:24
@irmatgit
Copy link
Copy Markdown
Contributor

irmatgit commented May 26, 2026 via email

@irmatgit
Copy link
Copy Markdown
Contributor

irmatgit commented Jun 3, 2026

Hi Elaine,

It is great to have these sources and their description in the repo!

Some improvement suggestions / questions:

  • "- IMAGE Integrated Assessment Model – Modeled load shapes by sector and end use by country, month, day type (weekday/weekend) and model year (1971 – 2100)"
    The word "country" here is a bit misleading. IMAGE dataset actually uses regions, like Western Europe isn't it ?

  • "- ERA5 + Demand Ninja Logic – Building-adjusted internal temperature (BAIT) and other weather variables for a representative location per country."
    Regarding the "representative location per country": could we be a bit more precise here ? Isn't it the most populated city in the country ?

Otherwise it looks good,

Thanks,

Matt

Copy link
Copy Markdown
Contributor

@irmatgit irmatgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conversation for my comments.
Otherwise, good to ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants