Documentation page describing data sources.#65
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 50 50
Lines 7935 7935
=======================================
Hits 5995 5995
Misses 1940 1940 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi Elaine,
My apologize but you caught me in a very busy period. I will look at it as soon as I have a bit of time. But that will be challenging next 2 weeks.
I'll get back to you on this!
Thanks,
MAtt
Sent from Outlook for Mac
From: Elaine Hale ***@***.***>
Date: Wednesday, 20 May 2026 at 17:29
To: dsgrid/stride ***@***.***>
Cc: Matthieu Irondelle ***@***.***>; Review requested ***@***.***>
Subject: Re: [dsgrid/stride] Documentation page describing data sources. (PR #65)
@elainethale<https://github.com/elainethale> requested your review on: dsgrid/stride#65<#65> Documentation page describing data sources..
—
Reply to this email directly, view it on GitHub<#65 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATJSLWWGFJRQQSI7LVGJ7MT43XFNZAVCNFSM6AAAAACYWIOBMGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRVG43DINRXGI2DCOA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.
…-------------------------------------------------------------------
The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorized use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you
|
|
Hi Elaine, It is great to have these sources and their description in the repo! Some improvement suggestions / questions:
Otherwise it looks good, Thanks, Matt |
irmatgit
left a comment
There was a problem hiding this comment.
See conversation for my comments.
Otherwise, good to ship.
No description provided.