Optimized where clause for search cursor at step 6.5#6
Open
fabanc wants to merge 1 commit into
Open
Conversation
Used the join function instead of multiple self-concatenations in order to build the where clause passed to the search cursor in step 6.5. This is much more efficient since strings are immutable. This also makes the code more readable and less verbose. Tested on Luxembourg, it makes step 6.5 processing time go from 25 seconds to 17 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the join function instead of multiple self-concatenations in order to build the where clause passed to the search cursor in step 6.5. This is much more efficient since strings are immutable. This also makes the code more readable and less verbose. Tested on Luxembourg, it makes step 6.5 processing time go from 25 seconds to 17 seconds.