Skip to content

Add CA bundle version and pinning status to the user agent string#52

Merged
AaronAtDuo merged 4 commits into
masterfrom
user-agent-ca-pinning
Jul 9, 2026
Merged

Add CA bundle version and pinning status to the user agent string#52
AaronAtDuo merged 4 commits into
masterfrom
user-agent-ca-pinning

Conversation

@cisco-dmytro-hissa

@cisco-dmytro-hissa cisco-dmytro-hissa commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

  • Added const CA_BUNDLE_VERSION = "1.0" constant
  • Updated the User-Agent header from duo_api_php/<version> to duo_api_php/<version> ca_bundle/<bundle_version> (ca_pinning=enabled|disabled) based on whether disable_ca_pinning is set in options

How Has This Been Tested?

  • Updated testUserAgent to assert the full user agent string including ca_bundle/1.0 (ca_pinning=enabled)
  • Added testUserAgentWithCaPinningDisabled to verify the user agent shows (ca_pinning=disabled) when pinning is turned off

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cisco-dmytro-hissa
cisco-dmytro-hissa marked this pull request as ready for review July 9, 2026 09:27
@AaronAtDuo
AaronAtDuo merged commit c97118b into master Jul 9, 2026
5 checks passed
@AaronAtDuo
AaronAtDuo deleted the user-agent-ca-pinning branch July 9, 2026 13:51
@jeffreyparker jeffreyparker mentioned this pull request Jul 21, 2026
Merged
2 tasks
jeffreyparker added a commit that referenced this pull request Jul 22, 2026
@jeffreyparker
Bump version to 1.3.0 (#55)
7227a61 
All feature PRs for the 1.3.0 release are merged:
- Disable CA pinning option (#51)
- User-agent CA bundle/pinning status reporting (#52)
- appendToUserAgent() method (#53)
- CURLOPT_CAPATH OS fallback prevention (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AaronAtDuo AaronAtDuo AaronAtDuo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cisco-dmytro-hissa @AaronAtDuo