Skip to content

Commit 47d9918

Browse files
authored
Run flaky tests first so they run even if other tests fail (#416)
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
1 parent 405fa95 commit 47d9918

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/docker_test.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: docker_test
1+
name: ddsrouter-docker-tests
22

33
on:
44
workflow_dispatch:
@@ -36,7 +36,7 @@ env:
3636
default_dependencies_artifact_postfix: '_nightly'
3737

3838
jobs:
39-
docker_test:
39+
docker-test:
4040

4141
runs-on: ubuntu-20.04
4242

@@ -119,7 +119,8 @@ jobs:
119119
colcon_meta_file: ${{ github.workspace }}/src/.github/workflows/configurations/${{ runner.os }}/colcon.meta
120120

121121
# Run ddsrouter_test compose tests
122-
- name: Run tests
122+
- name: Run flaky tests
123+
continue-on-error: true
123124
run: |
124125
export DDSROUTER_COMPOSE_TEST_DOCKER_IMAGE=${{ env.DDSROUTER_COMPOSE_TEST_DOCKER_IMAGE }}
125126
export DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE=${{ env.DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE }}
@@ -129,11 +130,10 @@ jobs:
129130
--event-handlers console_direct+ \
130131
--return-code-on-test-failure \
131132
--ctest-args \
132-
--label-exclude xfail \
133+
--label-regex xfail \
133134
--timeout 120
134135
135-
- name: Run flaky tests
136-
continue-on-error: true
136+
- name: Run tests
137137
run: |
138138
export DDSROUTER_COMPOSE_TEST_DOCKER_IMAGE=${{ env.DDSROUTER_COMPOSE_TEST_DOCKER_IMAGE }}
139139
export DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE=${{ env.DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE }}
@@ -143,5 +143,5 @@ jobs:
143143
--event-handlers console_direct+ \
144144
--return-code-on-test-failure \
145145
--ctest-args \
146-
--label-regex xfail \
146+
--label-exclude xfail \
147147
--timeout 120

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
# - test python linter
4848
#
4949

50-
name: test
50+
name: ddsrouter-tests
5151

5252
on:
5353

0 commit comments

Comments
 (0)