Add name property to ModelComponents, DiffusionModels and ComponentCollections#178
Add name property to ModelComponents, DiffusionModels and ComponentCollections#178henrikjacobsenfys wants to merge 6 commits into
Conversation
…llection and update tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #178 +/- ##
===========================================
- Coverage 98.12% 98.11% -0.01%
===========================================
Files 45 45
Lines 2874 2872 -2
Branches 511 514 +3
===========================================
- Hits 2820 2818 -2
Misses 34 34
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rozyczko
left a comment
There was a problem hiding this comment.
-
ComponentCollection.__init__still hasdisplay_namedefaulting to a string, which is inconsistent with the rest, where it defaults toNone(orname) -
DiffusionModelBasehas a separate__repr__that doesn't includename
| self._unit = unit | ||
|
|
There was a problem hiding this comment.
EasyDynamicsModelBase.__init__ already calls self._unit = _validate_unit(unit), so the second assignment overwrites it without validation. It's better to remove this assignment entirely.
This is needed for migrating to using EasyList #117 #70