fakecgo: restrict freebsd/netbsd build constraints to amd64/arm64#472
Closed
gdams wants to merge 1 commit into
Closed
fakecgo: restrict freebsd/netbsd build constraints to amd64/arm64#472gdams wants to merge 1 commit into
gdams wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates internal/fakecgo build constraints so that shared fakecgo files only build on freebsd/netbsd when the architecture is amd64 or arm64, matching the existing arch restrictions in the OS-specific implementations.
Changes:
- Narrow
//go:buildconstraints in shared fakecgo Go files to((freebsd || netbsd) && (amd64 || arm64)). - Keep
darwinandlinuxbehavior unchanged by leaving them unconstrained by arch in these files.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/fakecgo/go_util.go | Restricts fakecgo thread-start helper to freebsd/netbsd on amd64/arm64. |
| internal/fakecgo/go_setenv.go | Restricts fakecgo env helpers to freebsd/netbsd on amd64/arm64. |
| internal/fakecgo/go_libinit.go | Restricts fakecgo runtime-init helpers to freebsd/netbsd on amd64/arm64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // SPDX-FileCopyrightText: 2022 The Ebitengine Authors | ||
|
|
||
| //go:build !cgo && (darwin || freebsd || linux || netbsd) | ||
| //go:build !cgo && (darwin || linux || ((freebsd || netbsd) && (amd64 || arm64))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
What type of issue is this addressing?
bug
What this PR does | solves
This PR restricts the
freebsdandnetbsdbuild constraints in fakecgo's shared files (go_util.go, go_setenv.go, go_libinit.go) toamd64/arm64, matching the arch constraints already present in the OS-specific go_freebsd.go and go_netbsd.go files. This prevents build failures on unsupported architectures (e.g.freebsd/386), where the shared files would otherwise compile but reference symbols like_cgo_sys_thread_startthat are never defined.