Skip to content

fix(harmonia): cap dialogs to the viewport and scroll their body #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delchev merged 1 commit into from
Aug 27, 2026
+19 −0
Merged

fix(harmonia): cap dialogs to the viewport and scroll their body #6951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...application-core/src/main/resources/META-INF/dirigible/application-core/shell/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,22 @@ html, body { height: 100%; margin: 0; }
:root {
/* --primary: oklch(0.55 0.22 260); */
}

/*
* Cap Harmonia dialogs to the viewport and scroll their body.
* Harmonia's x-h-dialog is centred (top/left 50% + translate) with no max-height and
* no internal overflow, so a tall form dialog - e.g. the document line-item editor with
* many fields - grows past the screen and its header and Save/Cancel footer bleed off the
* top and bottom edges, unreachable. Capping the dialog and letting the content region
* (x-h-dialog-content) scroll keeps the header and footer pinned and on screen. Keyed on
* Harmonia's stable data-slot so it applies to every dialog on every shell.
*/
[data-slot="dialog"] {
max-height: calc(100vh - 2rem);
}

[data-slot="dialog"] [x-h-dialog-content] {
flex: 1 1 auto;
min-height: 0;
overflow-y: auto;
}
Loading