Skip to content

Remove 2018 deprecated runtime contenttype extension point#1644

Open
vogella wants to merge 2 commits into
eclipse-platform:masterfrom
vogella:delete-deprecated-extension-point
Open

Remove 2018 deprecated runtime contenttype extension point#1644
vogella wants to merge 2 commits into
eclipse-platform:masterfrom
vogella:delete-deprecated-extension-point

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Nov 27, 2024

Planned for 4.41

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

@HannesWell
Copy link
Copy Markdown
Member

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

eclipse-platform-bot commented Nov 27, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From fdd718ce2539ab4a146b4d1cfd79f941421da261 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 18 May 2026 07:55:40 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index 7ad1e9e8a7..240fd07538 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.34.200.qualifier
+Bundle-Version: 3.34.300.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Nov 27, 2024

Awesome @HannesWell that works. Thank you for the tip

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Nov 27, 2024

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

Will do.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2024

Test Results

    45 files   -   9      45 suites   - 9   38m 9s ⏱️ + 1m 23s
 4 513 tests  - 154   4 485 ✅  - 160   22 💤 ±0   6 ❌ + 6 
11 433 runs   - 462  11 262 ✅  - 480  153 💤 ±0  18 ❌ +18 

For more details on these failures, see this check.

Results for commit bc204b1. ± Comparison against base commit 4149373.

This pull request removes 154 tests.
org.eclipse.compare.tests.AsyncExecTests ‑ testCancelOnRequeue
org.eclipse.compare.tests.AsyncExecTests ‑ testQueueAdd
org.eclipse.compare.tests.AsyncExecTests ‑ testWorker
org.eclipse.compare.tests.CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFFX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFTX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

#2633

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 26, 2026

Removals are best done for M1 and not M3

vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point is being
removed in eclipse-platform/eclipse.platform#1644. Update the two
remaining test fixtures (regression test for bug 107121 in
OpenNavigatorFolderTest, and ObjectContributionTest) to contribute to
org.eclipse.core.contenttype.contentTypes instead.
vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point was removed
in eclipse-platform/eclipse.platform#1644. Update schema documentation
to reference the non-deprecated org.eclipse.core.contenttype.contentTypes
extension point instead.
In 2018 we marked this extension point for deletion, lets remove it for
2025-03.
@vogella vogella force-pushed the delete-deprecated-extension-point branch from 4991a2f to 9dc9b77 Compare May 18, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants