Outline: improve lazy expanding#409
Open
cguglielmo wants to merge 1 commit into
Open
Conversation
- Set lazyExpandingEnabled to true for Scout JS table pages Scout JS based table pages should expand lazily by default to make it consistent with Scout Classic table pages. - Ensure correct expandedLazy state (Scout JS) If lazyExpandingEnabled is disabled and the node updated, expandedLazy state should be set to false as well. - Outline.ts#.drillDown now also scrolls to the selected node like the Java implementation already does. - Don't expand table pages on drill down (Scout Classic) Currently, a double click on a table row in the detail table of a page always selects and expands the corresponding child page. This is fine for node pages, but if a table is expanded that has lazyExpandingEnabled set to true (default), a + is shown for the page in the outline but no child page is visible. This is confusing and also inconsistent to what the NavigateDown button does. This button does the expanding only for node pages (see Outline.ts#drillDown). Now, the Java based drillDown does the same as the JS based. - Moved ITreeUIFacade.setNodeSelectedAndExpandedFromUI to IOutline and renamed it to drillDown, because it is never called from ui. - Added IPage.computeExpandOnDrillDown which returns true for node pages. - Removed unused property isChildrenVolatile/setChildrenVolatile of ITreeNode. 337244
c5e9dcf to
2af5049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
337244