[2112] Handle Start and Done StateUsages#2164
Open
jerome-obeo wants to merge 1 commit into
Open
Conversation
jerome-obeo
force-pushed
the
jgo/enh/add-start-end-states-on-state-usage
branch
from
7927bdb to
a3cc319
Compare
jerome-obeo
changed the title
jerome-obeo
force-pushed
the
jgo/enh/add-start-end-states-on-state-usage
branch
3 times, most recently
from
66034a1 to
169ae9c
Compare
Bug: eclipse-syson#2112 Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
jerome-obeo
force-pushed
the
jgo/enh/add-start-end-states-on-state-usage
branch
from
169ae9c to
9a33edd
Compare
AxelRICHARD
reviewed
May 19, 2026
|
|
||
| === New features | ||
|
|
||
| - https://github.com/eclipse-syson/syson/issues/2112[#2112] [Diagram] Add tools to create Start and Done states, available on `StateUsage` and `StateDefinition` graphical nodes. |
Member
There was a problem hiding this comment.
[Diagram] => [diagrams]
Start => Start (italic)
Done => Done (italic)
states => StateUsages
| } | ||
|
|
||
| /** | ||
| * * Get all reachable elements of the type given by the {@link EClass} in the {@link ResourceSet} of the given type |
| Optional<Object> optPackage = this.objectSearchService.getObject(editingContext, GeneralViewWithTopNodesTestProjectData.SemanticIds.PACKAGE_1_ID); | ||
| assertThat(optPackage).isPresent().get().isInstanceOf(Package.class); | ||
| var parentPackage = (Package) optPackage.get(); | ||
| parentPackage.setDeclaredName("States"); |
Member
There was a problem hiding this comment.
Why do you rename the Package?
To test there is no conflicts with the standard library States.sysml?
If so it is a problem that has been fixed before, so unless I'm missing something here, I don't think it is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #2112
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests