Skip to content

ctf: remove sequence bit length calculation as it cannot be known#410

Open
arfio wants to merge 1 commit into
eclipse-tracecompass:masterfrom
arfio:ctf2-fix-sequence-length
Open

ctf: remove sequence bit length calculation as it cannot be known#410
arfio wants to merge 1 commit into
eclipse-tracecompass:masterfrom
arfio:ctf2-fix-sequence-length

Conversation

@arfio

@arfio arfio commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What it does

Remove the check for maximum size, as we do not yet know the size of the member fields at this point, so it is impossible to calculate the maximum number of bits that the sequence will take. Fixes #379

How to test

Open the issue attached trace.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@arfio, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 28 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43c3e5ca-8632-466a-a363-ad7e03f5204e

📥 Commits

Reviewing files that changed from the base of the PR and between b7b6114 and bebaaa8.

📒 Files selected for processing (1)
  • ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/types/SequenceDeclaration.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTF2 error read dynamic length arrays

1 participant