Correctly propagate the client request authority.#6224
Merged
Conversation
vietj
force-pushed
the
http-client-request-authority-5.1
branch
from
6bec203 to
a7ab8e7
Compare
Motivation: The HttpClientRequest authority should be properly set instead of being inherited from the connection authority. In addition we should let the client request to have no authority when desired (which can be desired to craft HTTP/2 without an authority). Changes: Correctly create the initial request authority from the options authority or the push authority pseudo header. Add test for these cases.
vietj
force-pushed
the
http-client-request-authority-5.1
branch
from
a7ab8e7 to
59304b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
HttpClientRequestauthority should be properly set instead of being inherited from the connection authority.In addition we should let the client request to have no authority when desired (which can be desired to craft HTTP/2 without an authority).
Changes:
Correctly create the initial request authority from the options authority or the push authority pseudo header.
Add test for these cases.