Integration candidate: engine upgrade and evidence hardening - #153
Merged
Merged
Conversation
Import upstream release v1.6.2 (ff5c8cc8) via the no-common-ancestor tree
delta (git diff v1.5.3..v1.6.2 | git apply --3way). All 86 non-merge commits
dispositioned in docs/superpowers/plans/2026-09-19-strix-162-disposition.md.
Substrate: MCP tool layer, cloud/platform CLI modules (unwired at the product
boundary), coverage/evidence pipeline, dedupe provider binding, resumable-agent
lifecycle, curated skills. strix/skills/tooling/{hurl,hypothesis}.md excluded
(sandbox ships neither tool); semantic_confusion.md's dead refs rewritten.
strix/skills/__init__.py now matches upstream exactly (telemetry gate moved out).
Owned ports (lyrashield/**, product-authoritative): config merge-persist with
linked LLM-connection invalidation and active-alias writes; provider-bound
dedupe credentials via resolve_dedupe_model; reasoning=max via top-level
extra_body and the LiteLLM-only prompt-cache gate; resumable/unreachable agent
model with claim_parent_notice and terminal-send refusal; clean_optional
nullish filters; session capability required for all viewer run data including
the launched run; markdown-it-py PDF renderer (new viewer dep); calibration
metadata rendering; _clean_title sanitize + legacy finding_class backfill;
stream_idle_timeout/max_tool_calls_per_turn settings parity; ZAI/GLM frontier
family; SDK default-key reset to None (env fallback stays live).
Gate: verify-controlled-derivative.sh updated to the v1.6.2 base — 14 modified
+ 2 reviewed deletions, +149/-258 footprint, digest 30b8c59d.
…release-candidate # Conflicts: # UPGRADES.md
…se-candidate # Conflicts: # lyrashield/runtime/session_manager.py
…e-candidate # Conflicts: # lyrashield/runtime/session_manager.py # scripts/customer-branding-allowlist.json
The Task-12 preflight probe runs inside the session-ownership scope; fake backends in the cleanup/attachment suites have no container attrs or exec, so exec=absent correctly fails preflight. Mock the probe seam — these suites exercise lifecycle and mount semantics, not probing.
…ors' into codex/integration-release-candidate
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds frozen local-source staging and provenance recording, strengthens diff-scope and attachment validation, bounds threat-model exports, aligns schema-version constants, updates tests, and advances the worker pin. ChangesRuntime integrity
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant SessionManager
participant FrozenStaging
participant Digest
participant Runner
participant RunJson
SessionManager->>FrozenStaging: copy local source tree
FrozenStaging->>Digest: hash staged tree
Digest-->>SessionManager: return source digest
SessionManager->>Runner: provide source_snapshots
Runner->>RunJson: record source and repository provenance
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 41.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 58 functions across 12 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ecryptoguru
marked this pull request as ready for review
September 20, 2026 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration of engine PRs #144–#152 plus corrective source and evidence hardening. The branch now includes current engine main (#144 and #146); merge commit
11ea4e1ahas the same source tree as the reviewed corrective headef653236.Changes: safe attachment staging/retry cleanup; redacted and manifest-bound threat evidence; revision-pinned repository acquisition; frozen copied-source byte receipts; no-follow directory traversal; fail-closed asserted DIFF when cleanliness is unknown. The controlled Strix derivative footprint remains unchanged.
Local proof on the final source tree: controlled-derivative gate passed (2,493 tests, 4 skipped; Ruff, mypy over 191 source files, Bandit), dependency audit found no known vulnerabilities, branding check and wheel/sdist build passed. Exact engine/app worker contract passed 347 tests. Fresh CI for
11ea4e1ais required before merge.Release boundary: this PR does not enable authenticated beta scans or outbound connectors. App pins must be advanced to the final engine main SHA after the approved engine merge. No production deployment or paid scan is authorized by this PR.
Summary by CodeRabbit
New Features
Bug Fixes