Fix ordering for AttachRequest as well#137
Merged
Merged
Conversation
bleggett
force-pushed
the
bleggett/fixup-attach-ordering
branch
2 times, most recently
from
0545ca6 to
f63c6d6
Compare
bleggett
force-pushed
the
bleggett/fixup-attach-ordering
branch
from
f63c6d6 to
24f2716
Compare
kaniini
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically doing what #45 did in CreateRequest, for AttachRequest as well - which I did not do at the time, but should have done.