Conversation
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.43% | 27/28 |
| 🟢 | Branches | 86.96% | 20/23 |
| 🟢 | Functions | 100% | 5/5 |
| 🟢 | Lines | 96.43% | 27/28 |
Test suite run success
11 tests passing in 2 suites.
Report generated by 🧪jest coverage report action from 088abf6
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 129/129 |
| 🟢 | Branches | 100% | 47/47 |
| 🟢 | Functions | 100% | 27/27 |
| 🟢 | Lines | 100% | 120/120 |
Test suite run success
75 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 088abf6
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 99.8% | 988/990 |
| 🟢 | Branches | 98.98% | 292/295 |
| 🟢 | Functions | 97.45% | 229/235 |
| 🟢 | Lines | 99.79% | 948/950 |
Test suite run success
538 tests passing in 25 suites.
Report generated by 🧪jest coverage report action from 088abf6
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 92.51% | 358/387 |
| 🟢 | Branches | 85.51% | 118/138 |
| 🟢 | Functions | 98.15% | 53/54 |
| 🟢 | Lines | 92.41% | 353/382 |
Test suite run success
117 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 088abf6
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 70.97% | 22/31 |
| 🔴 | Branches | 20% | 1/5 |
| 🟡 | Functions | 75% | 6/8 |
| 🟡 | Lines | 68.97% | 20/29 |
Test suite run success
4 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 088abf6
There was a problem hiding this comment.
Pull request overview
This PR fixes inline DOM formatting application by ensuring DOM adapter internals (caret + formatting) are instantiated early enough to receive tool-loading events and to be available before the first block adapter is created.
Changes:
- Eagerly initializes
FormattingAdapterandCaretAdapterwhen the DOM adapter plugin is constructed. - Adjusts Core initialization order to eagerly resolve key internal modules (
BlockRenderer,BlocksManager,SelectionManager) before plugins/tools are initialized, so adapter-related event listeners are registered in time.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dom-adapters/src/index.ts | Forces early instantiation of singleton DOM adapters to register listeners before tools load. |
| packages/core/src/index.ts | Reorders Core initialization to resolve internal modules before initializing plugins/tools. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…entifier` cast Agent-Logs-Url: https://github.com/editor-js/document-model/sessions/6cc8bf67-e04e-456b-920e-f7aff60aedda Co-authored-by: gohabereg <23050529+gohabereg@users.noreply.github.com>
Inline tools were not applied to the DOM tree because Adapter was initialized after tools were loaded. Caret and Formatting adapters were not initialized at all before first BlockToolAdapter is created
Fixed the order of initialization in this PR