Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Ghidra headless analysis script from using analyzeHeadless to PyGhidra's pyghidraRun, enabling better Python integration with Ghidra. The changes adapt the code to work with PyGhidra's environment and JPype's Java interoperability layer.
- Replaces
analyzeHeadlesswithpyghidraRunfor script execution - Updates Java interop to use JPype decorators instead of direct inheritance
- Modifies PrintWriter usage from
print()towrite()method - Adds PyGhidra virtual environment setup in CI workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| export.bash | Switches from analyzeHeadless to pyghidraRun with -H flag for headless mode |
| cpp_exporter_headless.py | Adds PyGhidra runtime annotation, JPype decorators, Python sort instead of Collections.sort, PrintWriter API corrections, and improved error handling |
| .github/workflows/test.yml | Creates PyGhidra virtual environment during CI setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.