Harden manuscript readiness validation - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The initial manuscript package validator mostly checked declared hashes and IDs. A stale or incomplete review could therefore remain apparently valid when source-manifest semantics changed, review modes were lowered, citation anchors were absent, or malformed receipt fields reached runtime paths.
Compatibility
This intentionally tightens schema-v1 readiness semantics. Existing packages remain readable but may return new findings until review packets, receipts, and hashes are regenerated.
target_venue: nullmeans internal handoff readiness, not venue compliance.Test plan
uv run python -m unittest tests.test_evidence_review_v2 tests.test_reviewer_runtime tests.test_manuscript_package tests.test_native_skill_quality— 48 passed./scripts/check.sh fast— 350 passed; all release and contract gates passed