Weekly schedule working#28
Conversation
|
@mRy0 Thanks for your contribution! Would it be possible that you open a pull request against v2 branch too? But first I can review this pull so we can merge it with master. |
|
|
||
| public override string ToString() | ||
| { | ||
| return $"DaySchedule Len: {DaySchedule?.Count()}"; |
|
|
||
|
|
||
|
|
||
| public int Decode(byte[] buffer, int offset, uint count) |
There was a problem hiding this comment.
Code cosmetics. Please remove extra new lines you added in some places like this, max one empty line is ok. And when you see a line wrapping here, then it means it's a bit too long, please try to make it shorter.
|
Retargeting to the Rather than merge it now, this will be incorporated when we synchronize the repository with the IPECON fork (https://github.com/IPECON/BACnet), which already contains similar Schedule support: During that sync we'll reconcile the two approaches: IPECON surfaces the seven daily schedules as separate values, whereas this PR packages Thanks @mRy0 for the original work. Tracked together with #26 / #131. |
|
@mRy0 schedules have been added in 4.0.0-beta.3, any feedback appreciated 🙇 |
2 participants
I wrote some code to get the weekly schedule working.
I added two classes BacnetDailySchedule struct with decode and encode and containing a List of BacnetTimeValue.
Reading and writing is testet against different ela certified PLCs.