Resolve Windows SDK ucrt path dynamically in build.rs - #13
Merged
Merged
Conversation
Co-authored-by: calladoum-elastic <85187342+calladoum-elastic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add dynamic MSVC_PATH for ucrt
Resolve Windows SDK ucrt path dynamically in build.rs
Sep 18, 2026
calladoum-elastic
marked this pull request as ready for review
September 18, 2026 19:05
calladoum-elastic
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows debug build was pinned to a single Windows SDK version via a hardcoded
MSVC_PATH, which breaks when only newer SDKs are installed. This updatesbuild.rsto resolve theucrtlibrary path dynamically instead of assuming10.0.22000.0.Windows SDK path resolution
build.rsMSVC_PATHoverride when providedWindows Kits\\10\\Liband selecting the newest SDK that containsucrt/x64Build-script invalidation
rerun-if-env-changedentries for the Windows SDK-related environment variables so Cargo rebuilds when the configured SDK path changesFocused build-script coverage