Fix comparer collection initializers#3328
Closed
theletterf wants to merge 3 commits into
Closed
Conversation
Replace unsupported comparer collection expressions with explicit constructors so main builds with the configured .NET SDK. Co-Authored-By: GPT-5.5 <noreply@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Use capacity-plus-comparer constructors for empty collections so CI preserves custom comparers without triggering IDE0028 as an error. Co-Authored-By: GPT-5.5 <noreply@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Use collection expressions as constructor input so style analyzers pass while the API explorer sets keep case-insensitive comparisons. Co-Authored-By: GPT-5.5 <noreply@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Silly me, this is because I wasn't on the latest .NET. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Current
mainfails to compile because the compiler treats the comparerwith(...)collection expressions as calls to a missing method.What
Replace those expressions with explicit
DictionaryandHashSetconstructors while preserving the intended case-insensitive comparers. Verified withdotnet build src/tooling/docs-builder/docs-builder.csproj -c Release --verbosity minimal.Made with Cursor