Skip to content

[EuiTab] Remove inline padding and update text colors - #9878

Draft
ryankeairns wants to merge 6 commits into
mainfrom
rk/reduce-tab-padding
Draft

[EuiTab] Remove inline padding and update text colors#9878
ryankeairns wants to merge 6 commits into
mainfrom
rk/reduce-tab-padding

Conversation

@ryankeairns

@ryankeairns ryankeairns commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Closes #9898

Summary

  • Removes the 4px inline padding from EuiTab so labels and the selected underline sit flush with the tab edge (#9817)
  • Updates tab text colors: inactive tabs use textSubdued, selected tabs use textHeading; selected underline remains primary blue

Before and After

Before After
CleanShot 2026-08-07 at 11 30 54@2x CleanShot 2026-08-07 at 11 31 32@2x

Test plan

  • Verify tabs on docs site (/docs/containers/tabs) — all sizes, selected/disabled, with prepend/append
  • Confirm inactive labels are subdued and selected label is heading color with blue underline
  • Confirm surrounding content can align flush to tab labels without padding workarounds
  • Approve VRT baseline updates in Buildkite after visual diffs post

Closes #9817

Made with Cursor

Flush tab labels to the edge and use subdued/heading text for inactive/selected tabs while keeping the primary underline.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ryankeairns
ryankeairns requested a review from a team as a code owner August 7, 2026 18:36
Copilot AI review requested due to automatic review settings August 7, 2026 18:36
Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates EuiTab styling to align tab label/underline edges flush with the tab boundary (removing the prior 4px inline padding) and to modernize label color semantics (inactive vs selected) while keeping the selected underline as primary blue.

Changes:

  • Removed horizontal padding from the base EuiTab styles so tab contents/underline align flush to the edge.
  • Updated default (inactive) tab text color to textSubdued.
  • Updated selected tab text color to textHeading while keeping the underline primary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
26 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euitabbedcontent (2 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile

euitabs (6 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
long tab content desktop
long tab content mobile
playground desktop
playground mobile

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
27 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euitabbedcontent (2 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile

euitabs (6 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
long tab content desktop
long tab content mobile
playground desktop
playground mobile

euidatagrid (1 difference)

StoryBeforeAfterDiff
compact desktop

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

Co-authored-by: Cursor <cursoragent@cursor.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
18 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
18 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

@ryankeairns
ryankeairns marked this pull request as draft August 7, 2026 21:24
Co-authored-by: Cursor <cursoragent@cursor.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
3 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euidatagrid (1 difference)

StoryBeforeAfterDiff
compact desktop

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
3 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euidatagrid (1 difference)

StoryBeforeAfterDiff
compact desktop

ryankeairns and others added 2 commits August 13, 2026 12:29
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
26 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euitabbedcontent (2 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile

euitabs (6 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
long tab content desktop
long tab content mobile
playground desktop
playground mobile

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
30 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euimarkdownformat (3 differences)

StoryBeforeAfterDiff
high contrast mobile
kitchen sink mobile
text props mobile

euiselectable (1 difference)

StoryBeforeAfterDiff
single selection desktop

euisuperdatepicker (2 differences)

StoryBeforeAfterDiff
custom time zone display desktop
custom time zone display mobile

euipage (12 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
legacy children only desktop
legacy children only mobile
playground desktop
playground mobile
responsive false desktop
responsive false mobile
responsive reverse desktop
responsive reverse mobile
wrapping content desktop
wrapping content mobile

euitabbedcontent (2 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile

euitabs (6 differences)

StoryBeforeAfterDiff
playground desktop
playground mobile
long tab content desktop
long tab content mobile
playground desktop
playground mobile

euipagetemplate (4 differences)

StoryBeforeAfterDiff
dark mode desktop
dark mode mobile
playground desktop
playground mobile

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Aug 13, 2026

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiTab] Quieter labels, less inline padding [EuiTab] Remove inline padding

2 participants