[EuiBasicTable][EuiDataGrid] Quieter default row action colors - #9902
Draft
ryankeairns wants to merge 4 commits into
Draft
[EuiBasicTable][EuiDataGrid] Quieter default row action colors#9902ryankeairns wants to merge 4 commits into
ryankeairns wants to merge 4 commits into
Conversation
Default table item actions and DataGrid cell/expand icons use text/empty instead of primary/fill so row chrome reads closer to body text. Pass color="primary" (and display="fill" for grid) to restore the previous look. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts default table/grid row & cell action icon styling to be visually quieter (closer to body text) as part of the ongoing visual refresh work, while keeping explicitly colored/custom-rendered actions unchanged.
Changes:
EuiBasicTable/EuiInMemoryTable: default item actioncolornow falls back totextinstead ofprimarywhen omitted.EuiDataGrid: hover cell action + expand icons now usecolor="text"withdisplay="empty"instead ofprimary/fill.- Updated relevant unit snapshots/types documentation to reflect the new defaults.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/eui/src/components/datagrid/body/cell/data_grid_cell_actions.tsx | Switches DataGrid hover action/expand button icon presentation to text/empty styling. |
| packages/eui/src/components/datagrid/body/cell/data_grid_cell_actions.test.tsx | Updates inline snapshots for the new button icon classes. |
| packages/eui/src/components/basic_table/default_item_action.tsx | Changes the default action color fallback from primary to text. |
| packages/eui/src/components/basic_table/action_types.ts | Documents the new default color (@default text) for action color fields. |
| packages/eui/src/components/basic_table/snapshots/expanded_item_actions.test.tsx.snap | Updates snapshots for default empty button styling changes. |
| packages/eui/src/components/basic_table/snapshots/default_item_action.test.tsx.snap | Updates snapshots for default action styling changes. |
| packages/eui/src/components/basic_table/snapshots/basic_table.test.tsx.snap | Updates kitchen sink snapshots to match the new default styling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
28 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuiheader (2 differences)
euimodal (2 differences)
euipopover (3 differences)
euibreadcrumbs (6 differences)
euibasictable (9 differences)
euiinmemorytable (1 difference)
euiautosizer (1 difference)
euii18n (4 differences)
|
This was referenced Aug 12, 2026
Contributor
|
😕 
We had an issue with our CI image which caused those typography visual diff. I merged in |
13 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuibasictable (9 differences)
euidatagrid (3 differences)
euiinmemorytable (1 difference)
|
12 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuibasictable (9 differences)
euidatagrid (2 differences)
euiinmemorytable (1 difference)
|
ryankeairns
marked this pull request as draft
August 12, 2026 14:49
67 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuidescriptionlist (1 difference)
euihealth (1 difference)
euitimeline (2 differences)
euitooltip (4 differences)
euiform (5 differences)
euisearchbar (1 difference)
euisuperdatepicker (19 differences)
euiflexgrid (1 difference)
euiheader (2 differences)
euimodal (1 difference)
euipage (6 differences)
euipanel (4 differences)
euibreadcrumbs (6 differences)
euisplitbutton (9 differences)
euisteps (1 difference)
euidatagrid (1 difference)
euitable (2 differences)
euiinnertext (1 difference)
|
💔 Build Failed
Failed CI StepsHistory
|
69 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuidescriptionlist (1 difference)
euihealth (1 difference)
euitimeline (2 differences)
euitooltip (4 differences)
euiform (5 differences)
euisearchbar (1 difference)
euisuperdatepicker (19 differences)
euiflexgrid (1 difference)
euiheader (2 differences)
euimodal (1 difference)
euipage (6 differences)
euipanel (4 differences)
euibreadcrumbs (6 differences)
euisplitbutton (9 differences)
euisteps (1 difference)
euidatagrid (3 differences)
euitable (2 differences)
euiinnertext (1 difference)
|
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #9899 (visual refresh) — action/icon quieting only. Does not address transparent row backgrounds /
hasBackground(still open on that issue).coloris nowtextinstead ofprimarywhen omittedcolor="text"+display="empty"instead of primary/fillcolor/ customrenderactions are unchangedSmall blast radius: only surfaces that relied on the previous defaults.
Test plan
colorlook neutral; explicitprimary/dangerunchangedyarn yo-changelog <PR#>)Made with Cursor