[EuiButtonGroup] Implement redesign #4 - Update Options API styles and implementations - #9953
[EuiButtonGroup] Implement redesign #4 - Update Options API styles and implementations#9953mgadewoll wants to merge 6 commits into
Conversation
a68e91f to
a4499d8
Compare
📷 36 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuifilterbutton (4 differences)
euifiltergroup (2 differences)
euisearchbar (4 differences)
euisuperdatepicker (6 differences)
euibuttongroup (14 differences)
euidatagrid (4 differences)
euiinmemorytable (2 differences)
|
a4499d8 to
e96822c
Compare
💔 Build Failed
Failed CI StepsHistory
cc @mgadewoll |
📷 36 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuifilterbutton (4 differences)
euifiltergroup (2 differences)
euisearchbar (4 differences)
euisuperdatepicker (6 differences)
euibuttongroup (14 differences)
euidatagrid (4 differences)
euiinmemorytable (2 differences)
|
💔 Build Failed
Failed CI StepsHistory
cc @mgadewoll |






































































































Summary
Note
This PR is part 4 of implementing the new button group design and API.
It builds on the selection variant that was added in part 3.
EuiButtonGroupwith the legacy Options API to use the new redesign styles aligning it with the styles of the previously added Children API. Additionally this PR updates all eui-internal usages.EuiFilterGroupstyles (base alignment update only; there will be a standalone PR to fully update the component as part of https://github.com/elastic/eui-private/issues/728)EuiSuperDatePicker'sTimeWindowButtonsto use the newEuiButtonGroupwith Children APIEuiDataGridsEuiDataGridColumnSortingDraggableandRowHeightControlandDensityControlbutton group usageseuiButtonSizeMapto provide an inset height viagetInsetHeightAPI Changes
EuiButtonGroup(Options API only)optionschildreninsteadEuiButtonGroup(Options API only)buttonSize="compressed"snow internally.EuiButtonGroup(Options API only)colorcolor="text"will be a static styling int he future.Screenshots
EuiFilterGroupEuiSuperDatePickerTimeWindowButtonsEuiDataGridcolumn sortingEuiDataGriddisplay selectorsImpact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None / 🟢 Low / 🟡 Moderate / 🔴 High
Release Readiness
QA instructions for reviewer
💻 Storybook
💻 Storybook kitchen sink
EuiButtonGroupwith Options API styles match the styles of the Children API withvariant="selection"backgrundLightTextcolor instead of regular text filled buttonbuttonSize="compressed"renders same assEuiFilterGroup(and internalEuiFilterButtonstyles are aligned with the new button group styles and there is no unexpected regressionEuiDataGrids display selection and column sorting use the new Children API button group and there is no functional regressionEuiSuperDatePickers time window buttons use the new Children API button group and there is no functional regressionChecklist before marking Ready for Review
breaking changelabel (if applicable)Reviewer checklist