Skip to content

Fix EuiFilterButtonObject isSelected spec - #9959

Merged
steliosmavro merged 1 commit into
elastic:mainfrom
steliosmavro:stelios/test-helpers-filter-button-fix
Aug 27, 2026
Merged

Fix EuiFilterButtonObject isSelected spec#9959
steliosmavro merged 1 commit into
elastic:mainfrom
steliosmavro:stelios/test-helpers-filter-button-fix

Conversation

@steliosmavro

Copy link
Copy Markdown
Contributor

Fixes a spec bug found via Weronika's report on chore/storybook-vite-builder. The isSelected spec set hasActiveFilters/isSelected via plain true/false strings in the Storybook args URL, which the Vite builder deserializes wrong (falls back to defaults, no error). Switched to Storybook's typed !true/!false arg syntax. Verified 20/20 against a Storybook build from that branch.

@steliosmavro
steliosmavro requested a review from a team as a code owner August 26, 2026 15:05
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

馃挌 Build Succeeded

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

馃挌 Build Succeeded

@steliosmavro
steliosmavro enabled auto-merge (squash) August 27, 2026 06:37
@steliosmavro steliosmavro added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Aug 27, 2026
@steliosmavro
steliosmavro merged commit 6d6d508 into elastic:main Aug 27, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants