[o365] Remove redundant filtering logic for non-cursor state

[chrisberkhout]

Proposed commit message

[o365] Remove redundant filtering logic for non-cursor state

#17540 added logic to filter out data in `state.cursor.todo_links` and
`state.cursor.todo_content` that isn't related to the currently
configured types. That's good. This PR adds an item for that in logic
overview comment at the top.

#17540 added similar filtering of `state.todo_types`, but that is
redundant because each config change or other restart will clear that
data already. This PR reverts that part and adds a comment to clarify.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.
• I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

• Relates o365: fix stale content types persisting in cursor after config changes #17540

[github-actions]

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

---

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

[elastic-vault-github-plugin-prod]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[infra-vault-gh-plugin-prod]

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

[efd6]

Do we want to make this more robust to user input like type1, , type2 (extra commas, with spaces). The previous code does this incidentally.

[chrisberkhout]

Yes, that's good. Added.

[efd6]

Suggested change

	state.base.content_types.split(",").map(t, t.trim_space()).filter(t, size(t) > 0)
	state.base.content_types.split(",").map(t, t.trim_space() != "", t.trim_space())

rather than making two arrays, and using "" instead of size so that it's clear we're dealing with strings.

Also, will need to regenerate the policy tests.

[chrisberkhout]

Done.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: d99ad76

History

• 💔 Build #44053 failed d5382aa
• 💚 Build #43885 succeeded 906ea54

[elastic-vault-github-plugin-prod]

Package o365 - 3.10.1 containing this change is available at https://epr.elastic.co/package/o365/3.10.1/