fix: address golangci-lint warnings#158
Open
andrewkroh wants to merge 15 commits into
Open
Conversation
andrewkroh
force-pushed
the
fix/linter-warnings
branch
5 times, most recently
from
8523016 to
ba94778
Compare
andrewkroh
added
the
Team:Security-Service Integrations
I think this reduces clarity when there are multiple embedded structs.
andrewkroh
force-pushed
the
fix/linter-warnings
branch
from
dbd2027 to
57a65cf
Compare
Replace tools.go with go mod tool directives. go get -tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint go get -tool github.com/elastic/go-licenser go mod tidy
Rename GcsOptions to GCSOptions.
Fixed an issue in TCP and TLS outputs where the write buffer was being modified, which is unsafe. A new buffer is now used.
Resolved a potential context leak in the GCS output by ensuring the cancel function is always called.
andrewkroh
force-pushed
the
fix/linter-warnings
branch
from
57a65cf to
42c0f59
Compare
💚 Build Succeeded
History
|
andrewkroh
commented
Nov 7, 2025
efd6
reviewed
Nov 9, 2025
| // KafkaOptions holds configuration for the Kafka output. | ||
| type KafkaOptions struct { | ||
| Topic string // Topic name. Will create it if not exists. | ||
| Topic string // Topic is the Kafka topic name. It will be created if it does not exist. |
Contributor
There was a problem hiding this comment.
"Topic is the Kafka topic name. The topic will be created if it does not exist."
("It" is Topic string on first reading)
Similar below.
Comment on lines
+17
to
+22
| // Initialize creates and configures a new Output using the provided Options and | ||
| // logger, then attempts to establish a connection with retries. It returns the | ||
| // connected Output or an error if the connection could not be established within | ||
| // the allowed retries or if the provided context is canceled. The logger is used | ||
| // for informational and debug messages during initialization and connection | ||
| // attempts. |
Contributor
There was a problem hiding this comment.
This doesn't look right (comment is in gutter).
| } | ||
|
|
||
| r.cmd.RunE = func(_ *cobra.Command, args []string) error { | ||
| r.cmd.RunE = func(_ *cobra.Command, _ []string) error { |
Contributor
There was a problem hiding this comment.
Just FYI, this could be r.cmd.RunE = func(*cobra.Command, []string) error {. No need for change.
| // the allowed retries or if the provided context is canceled. The logger is used | ||
| // for informational and debug messages during initialization and connection | ||
| // attempts. | ||
| func Initialize(ctx context.Context, opts *Options, logger *zap.SugaredLogger) (Output, error) { |
Comment on lines
+85
to
+89
| // Add a newline for framing. | ||
| buf := make([]byte, len(b)+1) | ||
| copy(buf, b) | ||
| buf[len(b)] = '\n' | ||
| return o.conn.Write(buf) |
Contributor
There was a problem hiding this comment.
In both cases this could be return o.conn.Write(append(b[:len(b):len(b)], '\n')) with safety.
Comment on lines
+63
to
+64
| if (opts.TLSCertificate != "" || opts.TLSKey != "") && | ||
| (opts.TLSCertificate == "" || opts.TLSKey == "") { |
Contributor
There was a problem hiding this comment.
if (opts.TLSCertificate == "") != (opts.TLSKey == "") {
or better
certIsZero := opts.TLSCertificate == ""
keyIsZero := opts.TLSKey == ""
if certIsZero != keyIsZero {
| if addr != "" { | ||
| h, err = url.Parse(addr) | ||
| if err != nil { | ||
| cancel() |
Contributor
There was a problem hiding this comment.
I think rather than doing this, NewClient should accept a context.Context and the caller should have the responsibility to handle this.
| if _, err = io.Copy(&buf, resp.Body); err != nil { | ||
| return 0, fmt.Errorf("failed to read response body: %w", err) | ||
| } | ||
| defer resp.Body.Close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a large number of golangci-lint warnings across the codebase.
The fixes span multiple categories of linters.
io.Copyandflag.Value.Set.gofumpt.io/ioutilwithioandospackages.zap.OnFatalwithzap.WithFatalHook._).context.Contextas the first argument.internal/output/tlsandinternal/output/udppackages to match their dir names.The only remaining linter warning is for the TODO in the udp output.