Add CustomCoglVapiTest and fix crash with mutter >= 47 - #2878
Open
lenemter wants to merge 3 commits into
Open
Conversation
lenemter
force-pushed
the
lenemter/fix-crash
branch
4 times, most recently
from
July 27, 2026 16:30
021d1d4 to
ef455e5
Compare
lenemter
marked this pull request as ready for review
July 27, 2026 16:35
lenemter
changed the title
lenemter
force-pushed
the
lenemter/fix-crash
branch
from
July 28, 2026 16:28
ef455e5 to
e52adeb
Compare
leolost2605
approved these changes
Jul 29, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
LGTM, one minor comment :)
| assert_cogl_color_is_white ("hsl(0, 0%, 100%)"); | ||
| assert_cogl_color_is_white ("hsla(0, 0%, 100%, 1)"); | ||
|
|
||
| assert_cogl_color_is_black ("#55555"); |
Member
There was a problem hiding this comment.
Maybe add a comment that invalid strings should return a black color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2868