Introduce LayoutManager - #2879
Open
leolost2605 wants to merge 3 commits into
Open
Conversation
leolost2605
marked this pull request as ready for review
July 29, 2026 18:36
Split the logic regarding UI layout out of WindowManagerGala and into a separate LayoutManager. The new LayoutManager handles settings things up and acts a little bit like a facade to the UI and widgets. The reason to do this is to reduce the size and complexity of WindowManagerGala and introduce some more explicit bounds between different parts of Gala.
leolost2605
force-pushed
the
leolost/layout-manager
branch
from
July 29, 2026 18:36
4ac41ee to
c361d08
Compare
lenemter
requested changes
Jul 30, 2026
lenemter
left a comment
lenemter
left a comment
Member
There was a problem hiding this comment.
I don't like making multitasking view / window overview private and adding methods to use them. Why don't just make them public at this point?
This comment was marked as outdated.
This comment was marked as outdated.
leolost2605
force-pushed
the
leolost/layout-manager
branch
from
July 31, 2026 16:33
c361d08 to
8dafe57
Compare
Member
Author
|
@lenemter I made the multitasking view and window overview public now. We also pass the window overview to the desktop integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the logic regarding UI layout out of WindowManagerGala and into a separate LayoutManager.
The new LayoutManager handles settings things up and acts a little bit like a facade to the UI and widgets.
The reason to do this is to reduce the size and complexity of WindowManagerGala and introduce some more explicit bounds between different parts of Gala.