Skip to content

Fast loop fprint auth to simulate simultaneous nonblocking logins with passwd auth #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vjr wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −9
Open

Fast loop fprint auth to simulate simultaneous nonblocking logins with passwd auth #884

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dde39a9
Fast loop fprint auth
vjr Jul 4, 2026
95c2e8b
Don't deadcode manual card login
vjr Jul 5, 2026
41b79dc
Break wrong-passwd auth loop for non-fprint users
vjr Jul 5, 2026
c6d3a40
Merge branch 'main' into fingerprint-loop
zeebok Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ public class Greeter.MainWindow : Gtk.ApplicationWindow {
private Greeter.DateTimeWidget datetime_widget;
private unowned LightDM.UserList lightdm_user_list;

private string? saved_credential = null;

private int current_user_card_index = -1;
private unowned Greeter.BaseCard? current_card = null;

Expand Down Expand Up @@ -270,10 +272,10 @@ public class Greeter.MainWindow : Gtk.ApplicationWindow {
case Greeter.FPrintUtils.MessageText.FPRINT_TIMEOUT:
case Greeter.FPrintUtils.MessageText.FPRINT_ERROR:
case Greeter.FPrintUtils.MessageText.OTHER:
current_card.use_fingerprint = false;
break;
default:
current_card.use_fingerprint = true;
saved_credential = null;
break;
}
}
Expand All @@ -286,6 +288,16 @@ public class Greeter.MainWindow : Gtk.ApplicationWindow {
((ManualCard) current_card).wrong_username ();
}
}

if (saved_credential != null) {
try {
lightdm_greeter.respond (saved_credential);
} catch (Error e) {
critical (e.message);
}
} else {
do_connect_username (((UserCard) current_card).lightdm_user.name);
}
}

// Called after the credentials are checked, might be authenticated or not.
Expand Down Expand Up @@ -328,6 +340,8 @@ public class Greeter.MainWindow : Gtk.ApplicationWindow {
}
}

saved_credential = null;

if (user_card != null) {
try {
lightdm_greeter.authenticate (user_card.lightdm_user.name);
Expand Down Expand Up @@ -492,14 +506,7 @@ public class Greeter.MainWindow : Gtk.ApplicationWindow {
}

private void do_connect (string? credential) {
if (credential != null) {
try {
lightdm_greeter.respond (credential);
} catch (Error e) {
critical (e.message);
}
}

saved_credential = credential;
carousel.interactive = false;
carousel.scroll_to (current_card);
}
Expand Down