Add :raise_on_missing_only option to Plug.Static#1286
Merged
josevalim merged 1 commit intoelixir-plug:mainfrom Sep 28, 2025
Merged
Add :raise_on_missing_only option to Plug.Static#1286josevalim merged 1 commit intoelixir-plug:mainfrom
josevalim merged 1 commit intoelixir-plug:mainfrom
Conversation
Add development-time validation to catch files that exist but aren't declared in the :only list. When enabled, raises MissingPathInOnlyFilterError with helpful guidance to either add the file to :only or use :only_matching for prefix-based matching. This prevents silent 404s when developers add static files (like favicon.svg) but forget to update the static file configuration, which is a common trap especially for digested files. Part of the fix for: phoenixframework/phoenix#6203
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add development-time validation to catch files that exist but aren't declared in the :only list. When enabled, raises MissingPathInOnlyFilterError with helpful guidance to either add the file to :only or use :only_matching for prefix-based matching.
This prevents silent 404s when developers add static files (like favicon.svg) but forget to update the static file configuration, which is a common trap especially for digested files.
Part of the fix for: phoenixframework/phoenix#6203