Skip to content

type=module#21371

Draft
NullVoxPopuli wants to merge 1 commit into
mainfrom
nvp/type-module
Draft

type=module#21371
NullVoxPopuli wants to merge 1 commit into
mainfrom
nvp/type-module

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented May 5, 2026

ember-source no longer depends on any v1 addons, so I think this is safe for all supported build environments (provided ci passes)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📊 Size report

Tarball size1.2 MB1.1 MB

dist/dev   -3.2%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/routing/-internals.js 733 B / 248 B -36.7%↓464 B / -38.7%↓152 B
./packages/router_js/index.js 55.5 kB / 11.8 kB -99.4%↓311 B / -98.7%↓157 B
./packages/rsvp/index.js 326 B / 192 B
./packages/shared-chunks/index-{hash}.js 78.5 kB / 19.1 kB -20.4%↓62.5 kB / -34.5%↓12.5 kB
./packages/shared-chunks/renderer-e0ynn50H.js 78.5 kB / 19.1 kB
./packages/shared-chunks/router-C9dQiKkw.js 55.4 kB / 11.7 kB
./packages/shared-chunks/rsvp-CnCSY930.js 63.6 kB / 12.7 kB
Total (Includes all files) 2 MB / 479.3 kB -3.2%↓1.9 MB / -2.72%↓466.3 kB

dist/prod   -3.51%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/router_js/index.js 55.5 kB / 11.8 kB -99.4%↓311 B / -98.6%↓160 B
./packages/rsvp/index.js 326 B / 192 B
./packages/shared-chunks/api-{hash}.js 8.3 kB / 1.8 kB -28.6%↓5.9 kB / -17.5%↓1.5 kB
./packages/shared-chunks/index-{hash}.js 66.5 kB / 16.3 kB -10.2%↓59.8 kB / -26%↓12.1 kB
./packages/shared-chunks/renderer-AU9Y4HfX.js 66.5 kB / 16.3 kB
./packages/shared-chunks/router-CK9qfBhI.js 55.4 kB / 11.7 kB
./packages/shared-chunks/rsvp-CnCSY930.js 63.6 kB / 12.7 kB
Total (Includes all files) 1.8 MB / 437.2 kB -3.51%↓1.8 MB / -2.94%↓424.3 kB

smoke-tests/v2-app-hello-world-template/dist   -31.8%↓

File Before (Size / Brotli) After (Size / Brotli)
./assets/main-{hash}.js 234.7 kB / 64.2 kB -31.9%↓159.8 kB / -30.3%↓44.8 kB
Total (Includes all files) 235 kB / 64.4 kB -31.8%↓160.2 kB / -30.2%↓44.9 kB

🤖 This report was automatically generated by wyvox/pkg-size

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

As a step one, I want:

  • all free-floating scripts to be in a package (at least one package)
  • all .js files to actually declare .cjs if they are cjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant