Skip to content

Convert cjs blueprint index.js files to 'cjs masquerading as esm' (in…#21427

Merged
NullVoxPopuli merged 1 commit into
mainfrom
nvp/cjs-masquerading-as-esm-but-intentionally
May 26, 2026
Merged

Convert cjs blueprint index.js files to 'cjs masquerading as esm' (in…#21427
NullVoxPopuli merged 1 commit into
mainfrom
nvp/cjs-masquerading-as-esm-but-intentionally

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented May 25, 2026

…tentionally) to take advantage of node's compatibility features to progress towards adding type=module on this package's package.json (which would make all these blueprint files real esm, not cjs pretending to esm)

Requires:

  • upgrade ember-cli #21423
    • but that, in turn, requires: Upgrade testem to latest #21425
    • this means that ember-source requires ember-cli 7+, and the blueprints provided by ember-source will no longer be compatible with ember-cli < 7 -- I think this is ok, because we don't really formally support mismatched ember-cli/ember-source majors, since we do lockstep and, we also require node's require(esm), so... we can do some nice things with that assumption

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   No changes

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/template-{hash}.js 1.1 kB / 401 B -54%↓491 B / -49.4%↓203 B
Total (Includes all files) 2 MB / 479.3 kB 2 MB / 479.3 kB

dist/prod   No changes

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/api-{hash}.js 8.3 kB / 1.8 kB -28.6%↓5.9 kB / -17.3%↓1.5 kB
Total (Includes all files) 1.8 MB / 437.2 kB 1.8 MB / 437.2 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 235 kB / 64.4 kB 235 kB / 64.4 kB

🤖 This report was automatically generated by wyvox/pkg-size

…tentionally) to take advantage of node's compatibility features to progress towards adding type=module on this package's package.json (which would make all these blueprint files real esm, not cjs pretending to esm)
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/cjs-masquerading-as-esm-but-intentionally branch from cb12cb5 to 0d5448e Compare May 26, 2026 16:40
@NullVoxPopuli NullVoxPopuli merged commit 978b72a into main May 26, 2026
44 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/cjs-masquerading-as-esm-but-intentionally branch May 26, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants