feat(frontend): migrate component to react server components for Transaction History Pagination - #1236
Merged
Conversation
|
@Abidoyesimze is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…on History Payment history previously fetched a hardcoded first page (LIMIT=50) and showed a static "End of list" message even though the backend already supports full page/limit/total_pages pagination. Extracts a pure, prop-driven TransactionHistoryPagination component (keyboard accessible, windowed page numbers, mobile-compact "Page X of Y" view) and wires real page navigation through the existing URL-driven filter state. A literal full React Server Component migration isn't compatible with this page's live WebSocket updates and instant client-side filtering, so the new component is deliberately data-fetching-free and controlled via props/ callback, making it trivially reusable if the page is ever split into a server shell + client island. Closes emdevelopa#1220 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Abidoyesimze
force-pushed
the
feature/fe-migrate-component-to-react-server-components-for-transaction-history-pagination
branch
from
July 24, 2026 20:04
96ec382 to
b81f90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payment-history/page.tsxinto a standalone, presentationalTransactionHistoryPaginationcomponent (keyboard-accessible prev/next + windowed page numbers, mobile-compact "Page X of Y" view).page/limit/total_pages, but the frontend hardcodedpage=1and just showed a static "End of list" message.recentPayments.paginationtranslations for en/es/pt.Note on "React Server Components"
A literal full RSC migration of this page isn't compatible with its live WebSocket payment updates and instant client-side filtering (both client-only APIs). Instead, the new pagination component is deliberately data-fetching-free and driven entirely by props/callback, so it's trivially reusable if the page is ever split into a server shell + client island later.
Test plan
vitest run src/components/TransactionHistoryPagination.test.tsx— 11/11 passing (rendering, prev/next boundaries, page-window collapsing with ellipsis,aria-current, disabled state)tsc --noEmitclean on touched fileseslintclean on touched filesCloses #1220
🤖 Generated with Claude Code